Test many calls continue to return random data

g105b · Jan 28, 2020 · b8c8598 · b8c8598
1 parent 532f4b2
commit b8c8598
Show file tree

Hide file tree

Showing 2 changed files with 23 additions and 1 deletion.
diff --git a/src/Random.php b/src/Random.php
@@ -51,7 +51,7 @@ private function getIv(int $size):string {
 				$originalAesCounter & 0xFF
 			) . $iv;
 
-			$originalAesCounter--;
+			$originalAesCounter >>= 8;
 		}
 
 		return str_pad(

diff --git a/test/phpunit/RandomTest.php b/test/phpunit/RandomTest.php
@@ -27,4 +27,26 @@ public function testSequenceIsNotSame() {
 
 		self::assertNotSame($output1, $output2);
 	}
+
+	public function testManyCalls() {
+		$sut = new Random();
+		$totalBytes = "";
+		$expectedLength = 0;
+		$previousByteArray = [];
+
+		for($i = 0; $i < 500; $i++) {
+			$newBytes = $sut->getBytes(16);
+			$expectedLength += 16;
+
+			$totalBytes .= $newBytes;
+			self::assertNotContains(
+				$newBytes,
+				$previousByteArray,
+				"Random bytes should never provide the same sequence twice"
+			);
+			$previousByteArray []= $totalBytes;
+		}
+
+		self::assertEquals($expectedLength, strlen($totalBytes));
+	}
 }