Combine extend in SetupGacela

gacela-project · Nov 14, 2022 · def3b70 · def3b70
1 parent de6296b
commit def3b70
Show file tree

Hide file tree

Showing 2 changed files with 49 additions and 8 deletions.
diff --git a/src/Framework/Bootstrap/SetupGacela.php b/src/Framework/Bootstrap/SetupGacela.php
@@ -341,6 +341,7 @@ public function combine(self $other): self
         $this->combineProjectNamespaces($other);
         $this->combineConfigKeyValues($other);
         $this->combineEventDispatcher($other);
+        $this->combineServicesToExtend($other);
 
         return $this;
     }
@@ -425,6 +426,19 @@ private function combineEventDispatcher(self $other): void
         }
     }
 
+    private function combineServicesToExtend(self $other): void
+    {
+        if ($other->isPropertyChanged('servicesToExtend')) {
+            foreach ($other->getServicesToExtend() as $serviceId => $otherServiceToExtend) {
+                $this->servicesToExtend[$serviceId] ??= [];
+                $this->servicesToExtend[$serviceId] = array_merge(
+                    $this->servicesToExtend[$serviceId],
+                    $otherServiceToExtend
+                );
+            }
+        }
+    }
+
     private function canCreateEventDispatcher(): bool
     {
         return $this->areEventListenersEnabled
@@ -460,23 +474,23 @@ private function setGenericListeners(?array $listeners): self
     }
 
     /**
-     * @param ?array<class-string,list<callable>> $listeners
+     * @param ?array<string,list<Closure>> $list
      */
-    private function setSpecificListeners(?array $listeners): self
+    private function setServicesToExtend(?array $list): self
     {
-        $this->markPropertyChanged('specificListeners', $listeners);
-        $this->specificListeners = $listeners ?? self::DEFAULT_SPECIFIC_LISTENERS;
+        $this->markPropertyChanged('servicesToExtend', $list);
+        $this->servicesToExtend = $list ?? self::DEFAULT_SERVICES_TO_EXTEND;
 
         return $this;
     }
 
     /**
-     * @param ?array<string,list<Closure>> $list
+     * @param ?array<class-string,list<callable>> $listeners
      */
-    private function setServicesToExtend(?array $list): self
+    private function setSpecificListeners(?array $listeners): self
     {
-        $this->markPropertyChanged('extendGlobalServices', $list);
-        $this->servicesToExtend = $list ?? self::DEFAULT_SERVICES_TO_EXTEND;
+        $this->markPropertyChanged('specificListeners', $listeners);
+        $this->specificListeners = $listeners ?? self::DEFAULT_SPECIFIC_LISTENERS;
 
         return $this;
     }

diff --git a/tests/Unit/Framework/Bootstrap/SetupGacelaTest.php b/tests/Unit/Framework/Bootstrap/SetupGacelaTest.php
@@ -4,6 +4,7 @@
 
 namespace GacelaTest\Unit\Framework\Bootstrap;
 
+use ArrayObject;
 use Gacela\Framework\Bootstrap\GacelaConfig;
 use Gacela\Framework\Bootstrap\SetupGacela;
 use Gacela\Framework\Event\Dispatcher\ConfigurableEventDispatcher;
@@ -174,4 +175,30 @@ public function test_combine_external_services(): void
             'service3' => new stdClass(),
         ], $setup->externalServices());
     }
+
+    public function test_combine_extend_service(): void
+    {
+        $setup = SetupGacela::fromGacelaConfig(
+            (new GacelaConfig())
+                ->extendService('service', static fn (ArrayObject $ao) => $ao->append(1))
+        );
+
+        $setup2 = SetupGacela::fromGacelaConfig(
+            (new GacelaConfig())
+                ->extendService('service', static fn (ArrayObject $ao) => $ao->append(2))
+                ->extendService('service-2', static fn (ArrayObject $ao) => $ao->append(3))
+        );
+
+        $setup->combine($setup2);
+
+        self::assertEquals([
+            'service' => [
+                static fn (ArrayObject $ao) => $ao->append(1),
+                static fn (ArrayObject $ao) => $ao->append(2),
+            ],
+            'service-2' => [
+                static fn (ArrayObject $ao) => $ao->append(3),
+            ],
+        ], $setup->getServicesToExtend());
+    }
 }