Feat: setup audio component #1587
Conversation
packages/loader/src/AudioLoader.ts
Outdated
| return new AssetPromise((resolve) => { | ||
| this.request<ArrayBuffer>(item.url, { type: "arraybuffer" }).then((arrayBuffer) => { | ||
| AudioManager.context.decodeAudioData(arrayBuffer).then((result) => { | ||
| resolve(result); |
| } | ||
|
|
||
| /** play the sound from the very beginning */ | ||
| public play() { |
| } | ||
|
|
||
| /** Current playback progress, in seconds */ | ||
| get position(): number { |
| * Plays the clip. | ||
| */ | ||
| play(): void { | ||
| if (!this._clip || !this.clip.duration || this.isPlaying) return; |
There was a problem hiding this comment.
this.clip.duration why not this._clip.duration?
| if (this.startTime > this._clip.duration || this.startTime < 0) return; | ||
| if (this._duration && this._duration < 0) return; | ||
|
|
||
| this._pausedTime = null; |
| @deepClone | ||
| private _endTime: number = null; | ||
| @deepClone | ||
| private _duration: number = null; |
There was a problem hiding this comment.
number init null is not good
packages/core/src/audio/AudioClip.ts
Outdated
| /** | ||
| * the number of discrete audio channels | ||
| */ | ||
| get channels(): Readonly<number> { |
There was a problem hiding this comment.
get channels(): number is OK
packages/core/src/audio/AudioClip.ts
Outdated
| private _audioBuffer: AudioBuffer; | ||
|
|
||
| /** | ||
| * the number of discrete audio channels |
There was a problem hiding this comment.
- Comments need to add a period，param comments do not need
- Capitalize the first letter
packages/core/src/audio/AudioClip.ts
Outdated
| /** | ||
| * get the clip's audio buffer | ||
| */ | ||
| getData(): AudioBuffer { |
There was a problem hiding this comment.
Avoid web native interfaces as much as possible
There was a problem hiding this comment.
I think getData and setData is a must
packages/core/src/audio/index.ts
Outdated
| @@ -0,0 +1,4 @@ | |||
| export { AudioManager } from "./AudioManager"; | |||
| super(entity); | ||
| const gain = AudioManager.context.createGain(); | ||
| gain.connect(AudioManager.context.destination); | ||
| AudioManager.listener = gain; |
| constructor(entity: Entity) { | ||
| super(entity); | ||
| const gain = AudioManager.context.createGain(); | ||
| gain.connect(AudioManager.context.destination); |
| AudioManager._context = new window.AudioContext(); | ||
| } | ||
| if (AudioManager._context.state !== "running") { | ||
| window.document.addEventListener("pointerdown", AudioManager._unlock, true); |
There was a problem hiding this comment.
Should do this when call context every time?
| return new AssetPromise((resolve, reject) => { | ||
| this.request<ArrayBuffer>(item.url, { type: "arraybuffer" }).then((arrayBuffer) => { | ||
| AudioManager.context | ||
| .decodeAudioData(arrayBuffer) |
There was a problem hiding this comment.
should do some encapsulation
There was a problem hiding this comment.
now it loads onto audioClip, not audio buffer
| const duration = this.endTime ? this.endTime - this._pausedTime : null; | ||
| this._play(this._pausedTime, duration); | ||
| } | ||
| } |
There was a problem hiding this comment.
What is the unique value that is different from play from the perspective of usage
| if (this.isPlaying) { | ||
| return this._pausedTime | ||
| ? this.engine.time.elapsedTime - this._absoluteStartTime + this._pausedTime | ||
| : this.engine.time.elapsedTime - this._absoluteStartTime + this.startTime; |
| @deepClone | ||
| private _endTime: number = null; | ||
| @deepClone | ||
| private _duration: number = null; |
| /** | ||
| * Stops playing the clip. | ||
| */ | ||
| stop(): void { |
There was a problem hiding this comment.
What is the unique value that is different from pause from the perspective of usage? It's call play form 0 next time?
There was a problem hiding this comment.
now only has play stop and pause, removed unpause
| return this._playbackRate; | ||
| } | ||
|
|
||
| set playbackRate(value: number) { |
There was a problem hiding this comment.
Your comments use speed, API use rate,try to use the unified concept
| set endTime(value: number) { | ||
| this._endTime = value; | ||
| this._duration = this._endTime - this._startTime; | ||
| } |
There was a problem hiding this comment.
You mean clip start and end time?
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
setup audio feature
UML API design
Other information:
Playground: galacean/galacean.github.io#752