Skip to content

add: metaMDBG wrapper #6998

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 14 commits into
base: main
Choose a base branch
from
Open

Conversation

Kulik7
Copy link

@Kulik7 Kulik7 commented May 19, 2025

Adding tool wrapper based on request #6578

FOR CONTRIBUTOR:

  • I have read the CONTRIBUTING.md document and this tool is appropriate for the tools-iuc repo.
  • License permits unrestricted use (educational + commercial)
  • This PR adds a new tool or tool collection
  • This PR updates an existing tool or tool collection
  • This PR does something else (explain below)

Copy link
Contributor

@bernt-matthias bernt-matthias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great Start. I added a few comments. The use of $__tool_directory__ needs to be fixed.

]]></command>

<inputs>
<conditional name="read_type">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the conditional is not really needed. Just a data and select parameter should be sufficient.


<tests>
<test expect_num_outputs="1">
<param name="read_type|type" value="ont" />
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you have a test for the other type?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not really, should I make one?

<filter type="regexp" column="0" value="^[0-9]+$" />
</options>
</param>
<param name="contigpath" type="boolean" checked="false"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of name="contigpath" use argument="--contigpath". This will also create the variuable $contigpath for the command block and additionally add (--contigpath) to the parameter help (then the user knows whioch Galaxy parameter controls which CLI ragument).

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

started in 5628499

@Kulik7
Copy link
Author

Kulik7 commented May 25, 2025

Thank you for the comments, I tried to work on the suggestions.
I was also trying to come up with test-files that would fit the size requirments, but I'm not sure it's possible to have a working example for MetaMDBG under 1 MB.

@martenson
Copy link
Member

martenson commented May 26, 2025

the tests for metamdbg pass for me locally in biocontainer, however metamdbg gfa ends with the same segfault as in github ci (visible at https://github.com/galaxyproject/tools-iuc/actions/runs/15249225749)

Job in error state.. tool_id: metamdbg_gfa, exit_code: 139, stderr: 
	Assembly dir: .
	Used k: 21
	Homopolymer compression: 0
	Data type: 1

Generating unitig sequences
Loading unitig sequences
Creating assembly graph file
/tmp/tmpxsakc5w0/job_working_directory/000/4/tool_script.sh: line 23:     9 Segmentation fault      (core dumped) metaMDBG gfa --assembly-dir . --k 21 --threads "${GALAXY_SLOTS:-1}"
.

so user sees the corresponding cli command
@martenson
Copy link
Member

manually running the metamdbg gfa test on the outputs of metamdbg runs fine locally

@bgruening
Copy link
Member

@martenson anythig I can help here? Is conda working and containers are crashing? Or what is the problem?

@martenson
Copy link
Member

@bgruening container works fine, I just need to have a closer look at the test, should have time next week

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants