-
Notifications
You must be signed in to change notification settings - Fork 459
add: metaMDBG wrapper #6998
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
add: metaMDBG wrapper #6998
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great Start. I added a few comments. The use of $__tool_directory__
needs to be fixed.
tools/metaMDBG/metaMDBG.xml
Outdated
]]></command> | ||
|
||
<inputs> | ||
<conditional name="read_type"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the conditional is not really needed. Just a data and select parameter should be sufficient.
tools/metaMDBG/metaMDBG.xml
Outdated
|
||
<tests> | ||
<test expect_num_outputs="1"> | ||
<param name="read_type|type" value="ont" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you have a test for the other type?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not really, should I make one?
tools/metaMDBG/metaMDBG_gfa.xml
Outdated
<filter type="regexp" column="0" value="^[0-9]+$" /> | ||
</options> | ||
</param> | ||
<param name="contigpath" type="boolean" checked="false" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of name="contigpath"
use argument="--contigpath"
. This will also create the variuable $contigpath
for the command block and additionally add (--contigpath)
to the parameter help (then the user knows whioch Galaxy parameter controls which CLI ragument).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
started in 5628499
Co-authored-by: Martin Cech <[email protected]>
…into metaMDBG-wrapper
Co-authored-by: Saim Momin <[email protected]>
Thank you for the comments, I tried to work on the suggestions. |
the tests for
|
so user sees the corresponding cli command
manually running the |
@martenson anythig I can help here? Is conda working and containers are crashing? Or what is the problem? |
@bgruening container works fine, I just need to have a closer look at the test, should have time next week |
Adding tool wrapper based on request #6578
FOR CONTRIBUTOR: