Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added WAYBAR_HIDDEN env var used to hide the waybar #210

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

Skerga
Copy link
Contributor

@Skerga Skerga commented Feb 8, 2025

Added a check for WAYBAR_HIDDEN=yes to the base-app image.

side effect is that this made it necessary to overwrite $HOME/.config/waybar/config.jsonc on every start to allow to switch between hidden and visible. Also every image using the base-app image will need to be rebuild.

i tested the change with a local build Lutris image and it worked fine.

@ABeltramo
Copy link
Member

There has to be a better way to do this without having to duplicate the full file.. I'll look to see if Waybar supports multiple config files and how it merges conflicting configs

@Skerga
Copy link
Contributor Author

Skerga commented Feb 9, 2025

I changed around the way i achieved hiding the waybar. I added a small python script that searches for, and changes the 3 variables i used for hiding the waybar.
its not yet perfect since there is no check if those 3 variables are in the config. if some are missing my script wont set them currently. I might also rewrite the script in the following days so it will be more robust.

I also thought about doing this fully in bash with sed but my sed skills aren't up for the task and imo sed always ends up looking way to cryptic to maintain

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants