Fixed things and cleaned up paths #8
Conversation
|
P.S. I have spoken with Sticker Mule and the main problem left with the Tux from the PR is the shadows on the outside of the feet. To be able to print designs in full bleed, their outer edges need to have 1/8th inch of flat color. However, I am not good with shadows and gradients and making things look good. Would you mind trying to make the parts of the feet marked in red be flat color about 1/8th of an inch deep? https://i.imgur.com/W3UR5EP.png |
|
I just checked out the PR. Thanks! (I don't often check GitHub on the weekends and didn't get around to it yesterday; sorry for the delay.) However, when ungrouping Tux in the main The other files work as expected. |
|
Oh. I reset to what's in the master branch and I'm seeing the same behavior in Inkscape 1.0 (crashing). |
|
Apparently, I was still on master when testing this. What's in the PR works... and master is apparently crashing Inkscape 1.0 for some reason. Whoops! Meanwhile, in commit b66ea70, the tux-bw-inverted.svg and png were both updated to look different from before. (The intent is to have a Tux on an dark background, and have an outline to protect how Tux looks.) |
|
Most welcome and no problem for the delay! As for tux-bw-inverted.svg and png, sorry, I didn't really understand that. Are you saying that they are ok like they are in the PR or that they are not? If it's the latter, what changes should I do to them? Also, did you had a chance to check my comment above about the feet gradients? |
|
Using the diff viewer @ https://github.com/garrett/Tux/pull/8/files#diff-bc5df85fa4a378ee83cbabb5928cfef7 show the difference — this affects both the SVG and PNG, of course. Here's a screenshot:
Differences:
The problems are 1, 2, and 3. |
|
As far as the gradient on the feet are concerned: That would change the way tux looks. Perhaps we should have a separate file for printing stickers? Like Ideally, yes, it would be nice if there could be just one file; I just want the default tux to look like the official one that Larry made. But if that's not good enough for printing stickers, we should have one that's authentic as possible and adjusted to be more optimal for printing. |
|
Not sure why I got confused and got the inverted Tux inverted :D Ah! Good point about keeping it as close to the original as possible. Now the only thing that's left is merge this and create the sticker version with the adjusted feet shadows. Everything has been fixed (the bw inverted and the rest have been regenerated again from the the regular Tux after the arm has been refined and Sticker Mule have confirmed that the arm is now ok for full bleeding). This is what I mean about the arm: (I remembered that the hand shadow also comes a bit too close to the outline for full bleed printing, however the arm seems more curved and closer to the hand than Larry's version, so I will just adjust that) Also, here is a pdf from Sticker Mule that hopefully better illustrates how much from the feet edges they should be solid (from the blue outline outwards): |
|
Bump :D |
- Added IFo Hancroft to the README - Everything has been ungrouped and regrouped again, so there should be no difference when Tux is ungrouped - Merged duplicate and overlapping nodes - Reworked clips from revised objects - Fixed a sharp point in the right foot - Fixed spiro spline artifacts where arms & body meet - Fixed spiro splite artifact in the neck - Fixed right foot highlight that was sticking outside of the foot - Every path and group has been named appropriately (even clip objects) - Additional minor modifications
It's that way in master too. Either I goofed up at some point, or it was changed in the previous PR (and I goofed up by letting it through without checking it). Oops. I've adopted all the commits to tux.svg, tux-large.png, and the README file. Additionally, I squashed it all to one commit. As for the other files, I moved those to another branch and will send that up as a PR. I've split the two out, because I want the changes you made to Tux to be merged ASAP and we can go over what to do about the black and white version in a separate PR. (I intentionally simplified the paths in the black and white version for better printing — especially at small sizes — and easier integration in other projects where needed. I'm thinking we have two versions: One more true, like yours, and a simplified version. But we can discuss this and work on it in the other PR I'm about to make.) |
|
Thanks! Merged. Continued in #9 for the BW variants. |
Thank you too! Will write in the other PR now :D |
|
I've opened an issue for the sticker @ issue #10. |
I have fixed and/or cleaned up the following things:
-- Everything has been ungrouped and regrouped again so in theory there should no longer be a difference between the grouped and ungrouped versions.
-- Merged duplicated/overlapping nodes where I have found them.
-- Redone the clips where the objects from which they were made have been changed
-- Fixed a sharp point in the right foot
-- Fixed a bump and a sharp point in the left and right arms/body meeting points and a bump in the neck that were caused by path effect spiro spline and arms
-- Fixed right foot highlight that was sticking outside of the foot
-- Every path and group has been named appropriately (even the clip objects)
-- A couple more things that I forgot to mention.
TL;DR: This PR fixes all the bugs that were left and cleans up everything that was left to be cleaned up. I may have missed some duplicated/overlapping nodes but they weren't causing problems so I haven't noticed them and I have already fixed everything else so I didn't want to go through everything again to check.
I have re-created the other vector images and png exports from the main one and have added myself to the README.