Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up .gitignore #246

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Clean up .gitignore #246

wants to merge 2 commits into from

Conversation

szepeviktor
Copy link
Contributor

There were contradictions in .gitignore.

szepeviktor
szepeviktor commented Jun 10, 2023
View reviewed changes
.gitignore
!vendor/composer
!vendor/firebase
!vendor/ircmaxell
vendor/composer/installed.json
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ignoring vendor and not ignoring vendor/composer then ignoring vendor/composer/installed.json does not work in git.

@szepeviktor
Copy link
Contributor Author

szepeviktor commented Jun 10, 2023 •
edited
Loading

@jasonbahl Actually everything above is a work-around.

At the end it can be checked: git ls-files --ignored --exclude-standard

justlevine added a commit to justlevine/wp-gatsby that referenced this pull request Jun 12, 2023
@justlevine
chore: update gitignore
4dd774a 
Includes gatsbyjs#246 and adds tests/_output
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@szepeviktor