Add test for file-level Boundary

gauge-sh · Feb 7, 2024 · 51692e9 · 51692e9
1 parent cb53970
commit 51692e9
Show file tree

Hide file tree

Showing 5 changed files with 18 additions and 10 deletions.
diff --git a/modguard/core/boundary.py b/modguard/core/boundary.py
@@ -12,7 +12,6 @@ class Boundary:
 
 @dataclass
 class BoundaryNode:
-    name: str = ""
     public_members: dict[str, PublicMember] = field(default_factory=dict)
     children: dict = field(default_factory=dict)
     is_end_of_path: bool = False

diff --git a/tests/example/__init__.py b/tests/example/__init__.py
@@ -1,7 +1,11 @@
 from modguard import Boundary
+
+# intentional import violations
 from .domain_one.interface import domain_one_interface
 from .domain_three.api import public_for_domain_two
+from .domain_four.subsystem import private_subsystem_call
 
+# OK import
 import example.domain_four
 
 # modguard-ignore

diff --git a/tests/example/domain_four/__init__.py b/tests/example/domain_four/__init__.py
@@ -1,3 +0,0 @@
-from modguard import Boundary
-
-Boundary()

diff --git a/tests/example/domain_four/subsystem.py b/tests/example/domain_four/subsystem.py
@@ -0,0 +1,7 @@
+from modguard import Boundary
+
+Boundary()
+
+
+def private_subsystem_call():
+    ...
diff --git a/tests/test_check.py b/tests/test_check.py
@@ -18,16 +18,17 @@ def test_has_boundary():
 
 def test_get_imports():
     assert get_imports("example/domain_one/interface.py") == ["modguard.public"]
-    assert get_imports("example/domain_one/__init__.py") == [
+    assert set(get_imports("example/domain_one/__init__.py")) == {
         "modguard.Boundary",
         "example.domain_one.interface.domain_one_interface",
-    ]
-    assert get_imports("example/__init__.py") == [
+    }
+    assert set(get_imports("example/__init__.py")) == {
         "modguard.Boundary",
         "example.domain_one.interface.domain_one_interface",
         "example.domain_three.api.public_for_domain_two",
         "example.domain_four",
-    ]
+        "example.domain_four.subsystem.private_subsystem_call",
+    }
 
 
 def test_check():
@@ -48,9 +49,9 @@ def test_check():
             boundary_path="example.domain_one",
         ),
         ErrorInfo(
-            import_mod_path="example.domain_four",
+            import_mod_path="example.domain_four.subsystem.private_subsystem_call",
             location="example/__init__.py",
-            boundary_path="example.domain_four",
+            boundary_path="example.domain_four.subsystem",
         ),
     ]
     check_results = check("example")