Handle missing dynamic imports #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t found in mark_as_public
caelean
reviewed
Feb 13, 2024
| print(f"Error marking {write_op.operation} in {write_op.location}") | ||
| print( | ||
| f"Error marking {write_op.operation.value}" | ||
| f"{'({member})'.format(member=write_op.member_name) if write_op.member_name else ''}" |
There was a problem hiding this comment.
never seen a format call inside an f string lol might be worth doing this formatting outside of the print() call
caelean
approved these changes
Feb 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If
mark_as_publicfails to find the specified member_name in the file_path, we previously raised an error.Now we will add a call to
public()with the member_name used as a string literal argument. This is also now recognized by the public member visitor.