Skip to content
This repository has been archived by the owner on Nov 5, 2024. It is now read-only.

Add an icon to indicate that a card is in the QA column #21

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

huntlisa
Copy link
Contributor

@huntlisa huntlisa commented Jan 8, 2019

I think that this should show a question mark in a circle when the state is QA - I collected the workflow state IDs from the Clubhouse API so that we had a way to check this.

@danbahrami
Copy link
Contributor

Thanks for submitting Lisa. I'm reluctant to accept this because I am considering, at some point, the option of whitelisting/open-sourcing Keeper. Because of that I'm trying to move away from hardcoding values such as workflow IDs.

I can see the value of knowing what card is in QA so I can have a look to see if there is a way to do this that works with the Clubhouse API. If you have any ideas let me know.

@huntlisa
Copy link
Contributor Author

huntlisa commented Jan 17, 2019

@danbahrami The only way that I could find to get workflow states (which is what our QA column is) involved pulling the list and then grabbing the IDs.

That said, when you grab the list, it creates an array containing the ids and the names. I think it would definitely be possible to collect/save workflow state ids and names and map them somehow without hard coding them.

Projects belong to Teams and so do workflows so if you have the team_id stored somewhere you could use it to find the possible state for the stories within the project.

{"entity_type":"workflow","id":500000009,"created_at":"2016-09-01T08:43:22Z","updated_at":"2018-01-31T11:03:59Z","name":"Default","description":"","team_id":4882,"default_state_id":500000014,"states":[{"description":"Work related to this project that has no immediate time frame.","entity_type":"workflow-state","color":"","verb":"","name":"Unscheduled","num_stories":1775,"type":"unstarted","updated_at":"2016-11-01T10:23:28Z","id":500000014,"position":0,"created_at":"2016-09-01T08:43:22Z"},{"description":"Stuff that we plan to do so soon, but not next week","entity_type":"workflow-state","color":"","verb":"","name":"Soon","num_stories":300,"type":"unstarted","updated_at":"2017-11-27T11:33:51Z","id":500059245,"position":1,"created_at":"2017-11-27T11:33:02Z"},{"description":"Work we're likely to pick up next week","entity_type":"workflow-state","color":"","verb":"","name":"Up Next","num_stories":313,"type":"unstarted","updated_at":"2016-11-01T10:22:15Z","id":500004373,"position":2,"created_at":"2016-11-01T10:20:11Z"},{"description":"Work that's ready to go this week","entity_type":"workflow-state","color":"","verb":"","name":"Ready","num_stories":307,"type":"unstarted","updated_at":"2016-11-01T10:22:30Z","id":500000011,"position":3,"created_at":"2016-09-01T08:43:22Z"},{"description":"","entity_type":"workflow-state","color":"","verb":"start","name":"Doing","num_stories":102,"type":"started","updated_at":"2016-11-01T10:20:53Z","id":500000015,"position":4,"created_at":"2016-09-01T08:43:22Z"},{"description":"","entity_type":"workflow-state","color":"","verb":"","name":"QA","num_stories":8,"type":"started","updated_at":"2018-01-31T11:03:59Z","id":500074438,"position":5,"created_at":"2018-01-31T11:03:59Z"},{"description":"","entity_type":"workflow-state","color":"","verb":"done","name":"Done","num_stories":6036,"type":"done","updated_at":"2016-09-02T15:05:33Z","id":500000012,"position":6,"created_at":"2016-09-01T08:43:22Z"}]}

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants