Skip to content

Added Face Recognition Script #115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

Aayush-hub
Copy link
Contributor

Added Face Recognition script using OpenCv.
Fixes: #15

@Aayush-hub
Copy link
Contributor Author

@geekquad Implemented in .ipynb format. Please review my PR.

Copy link
Owner

@geekquad geekquad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @Aayush-hub, I cannot exactly see any Image Processing technique being used here.
Please let me know If I have missed out on something.
We are looking for implementation and not the application of a technique. I can also see that you have used KNeighborsClassifier which is clearly against our standards.
Feel free to tell us if we have missed out on something.

@Aayush-hub
Copy link
Contributor Author

Hey @Aayush-hub, I cannot exactly see any Image Processing technique being used here.
Please let me know If I have missed out on something.
We are looking for implementation and not the application of a technique. I can also see that you have used KNeighborsClassifier which is clearly against our standards.
Feel free to tell us if we have missed out on something.

@geekquad When we collect data which is images it gets stored in a .npy file and in reference to those images the KNN classifier recognizes images. So image processing technique is definitely used in it, because image recognition is only working by processing images which is collected by user and saved in .npy file!

@geekquad
Copy link
Owner

geekquad commented Apr 7, 2021

Hey @Aayush-hub, I cannot exactly see any Image Processing technique being used here.
Please let me know If I have missed out on something.
We are looking for implementation and not the application of a technique. I can also see that you have used KNeighborsClassifier which is clearly against our standards.
Feel free to tell us if we have missed out on something.

@geekquad When we collect data which is images it gets stored in a .npy file and in reference to those images the KNN classifier recognizes images. So image processing technique is definitely used in it, because image recognition is only working by processing images which is collected by user and saved in .npy file!

Hey @Aayush-hub, which Image Processing technique is exactly being used here?

@Aayush-hub
Copy link
Contributor Author

Aayush-hub commented Apr 8, 2021

Hey @Aayush-hub, I cannot exactly see any Image Processing technique being used here.
Please let me know If I have missed out on something.
We are looking for implementation and not the application of a technique. I can also see that you have used KNeighborsClassifier which is clearly against our standards.
Feel free to tell us if we have missed out on something.

@geekquad When we collect data which is images it gets stored in a .npy file and in reference to those images the KNN classifier recognizes images. So image processing technique is definitely used in it, because image recognition is only working by processing images which is collected by user and saved in .npy file!

Hey @Aayush-hub, which Image Processing technique is exactly being used here?

@geekquad Linear filtering, Image Classification

@geekquad geekquad added Under Review Pull Request in being reviewed. gssoc21 GirlScript Summer Of Code 2021 Level3 New features, major bug fixing labels Apr 18, 2021
@Aayush-hub Aayush-hub requested a review from geekquad April 21, 2021 15:55
@geekquad
Copy link
Owner

image
Readme has no Image under Screenshot Heading.

@geekquad geekquad removed Level3 New features, major bug fixing gssoc21 GirlScript Summer Of Code 2021 labels May 21, 2021
@Aayush-hub
Copy link
Contributor Author

image
Readme has no Image under Screenshot Heading.

@geekquad Please check now!

@geekquad geekquad added gssoc21 GirlScript Summer Of Code 2021 Level3 New features, major bug fixing and removed Under Review Pull Request in being reviewed. labels Jun 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gssoc21 GirlScript Summer Of Code 2021 Level3 New features, major bug fixing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Face-Recognition script
2 participants