-
-
Notifications
You must be signed in to change notification settings - Fork 352
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add --cert-name and --deploy-hook options #230
base: master
Are you sure you want to change the base?
Conversation
Does someone know why this fails? Seems unrelated to my PR:
|
0425d5d
to
943abd8
Compare
This PR fixes the CI issue and adds --cert-name and --deploy-hook. It would have been nice to have a second domain to test adding certificates in the CI. @geerlingguy I would be very happy if you could review+merge this PR :) |
How do these changes interact with the updates from #208 from @theS1LV3R ? Sorry don't have time to do a full review at the current moment :) |
So at least for me, this PR makes |
Is it possible to rebase this PR on master? I don't see the changes from https://github.com/geerlingguy/ansible-role-certbot/pull/208/files being updated, it looks like the branch forks from somewhere prior to current master. |
Can be used like this: