Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable bootconfig support in genkernel #42

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions defaults/linuxrc
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,7 @@ run busybox --install -s
CMDLINE=$(cat /proc/cmdline 2>/dev/null)
for x in ${CMDLINE}
do
x=${x//\"/}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, I realized there IS a problem here.
If there are arguments with significant double-quotes, e.g. due to embedded whitespace, this would break them.

They are probably also partially broken already, so now is a good time to fix them.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't thought about the embedded whitespace, so do you have any better solution for this? (my knowledge with bash is kind of limited)

case "${x}" in
real_root=*)
REAL_ROOT=${x#*=}
Expand Down