-
Notifications
You must be signed in to change notification settings - Fork 172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OCI Support for manifests command and server tags page #202
base: master
Are you sure you want to change the base?
Conversation
Note that this loosens the checks for the returned manifest and simply returns a bag of bytes from registry
Thank you, I am quite interested in this feature as well! What if the endpoint returns an OCI index instead of an image manifest? |
The endpoint shouldn't return an index. The accept header I send to the server is only asking for v2 and OCI manifest types. That said, if it were to return an index for some reason, there's no longer validation of the return data, so |
This PR allows OCI images to be displayed through the manifest command. It also fixes my scenario on #173 which was caused by the create date being determined via a docker v1 manifest. That is now determined by getting a v2/OCI manifest, then acquiring the resultant config blob from the registry that should have the create date (we luck out that both docker v2 and OCI config json have createdDate in the base object).