Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCI Support for manifests command and server tags page #202

Open
wants to merge 18 commits into
base: master
Choose a base branch
from

Conversation

elerch
Copy link

@elerch elerch commented Mar 7, 2020

This PR allows OCI images to be displayed through the manifest command. It also fixes my scenario on #173 which was caused by the create date being determined via a docker v1 manifest. That is now determined by getting a v2/OCI manifest, then acquiring the resultant config blob from the registry that should have the create date (we luck out that both docker v2 and OCI config json have createdDate in the base object).

Note that this loosens the checks for the returned manifest
and simply returns a bag of bytes from registry
@athos-ribeiro
Copy link

Thank you, I am quite interested in this feature as well!

What if the endpoint returns an OCI index instead of an image manifest?

@elerch
Copy link
Author

elerch commented Mar 7, 2020

The endpoint shouldn't return an index. The accept header I send to the server is only asking for v2 and OCI manifest types.

That said, if it were to return an index for some reason, there's no longer validation of the return data, so reg manifest would return the resultant data, and the tags page rendered from the server command would fail to operate.

@athos-ribeiro
Copy link

Hi @jessfraz,

@elerch branch has been diverging a bit from upstream, and his changes seem to be quite useful!

Do you need help with a thorough review on thins (or any other) PR and issues here? I'd be more than willing to help providing those and pinging you when they are done :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants