PB-931 Change behavior of exc_text and stack_info - #major #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schtibe
force-pushed
the
feat-pb-931-python-exception-logging
branch
3 times, most recently
from
8553ff5 to
f6cd651
Compare
schtibe
changed the title
github-actions
bot
changed the title
ltshb
reviewed
Jan 13, 2025
There was a problem hiding this comment.
I don't fully understand what was the issue, because this repository is public and that this library is also public in pypi, we should document this change to be more understandable. Does it affect the use of the library with other framework like Flask ? Having some unittest that test the issue would be also very good.
schtibe
force-pushed
the
feat-pb-931-python-exception-logging
branch
5 times, most recently
from
46fd92b to
57ce5b6
Compare
schtibe
changed the title
github-actions
bot
changed the title
github-actions
bot
changed the title
schtibe
force-pushed
the
feat-pb-931-python-exception-logging
branch
from
57ce5b6 to
e3da9ed
Compare
boecklic
approved these changes
Jan 14, 2025
ltflb-bgdi
approved these changes
Jan 15, 2025
schtibe
force-pushed
the
feat-pb-931-python-exception-logging
branch
4 times, most recently
from
f4584be to
697ea5a
Compare
ltshb
approved these changes
Jan 17, 2025
schtibe
force-pushed
the
feat-pb-931-python-exception-logging
branch
from
697ea5a to
76f2ec1
Compare
schtibe
force-pushed
the
feat-pb-931-python-exception-logging
branch
2 times, most recently
from
9a2dce9 to
edd3814
Compare
Adding the exc_text field to the record before formatting a message. This allows for formatting the message through the django logging facility Removing the addition of exc_text to the message directly. Instead adding it to the record, so that it can be formatted through the django logging facility
Add the stack info to the record instead of the message directly in JSON formatter. This way it can be configured through the Django logging facility
Document the changes made with regards to logging the traceback.
schtibe
force-pushed
the
feat-pb-931-python-exception-logging
branch
from
edd3814 to
67e0651
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changing the
exc_textandstack_infobehavior.Instead of attaching these fields directly to the message by default we pass it to the formatter. This allows fore more control through the configuration, for instance through specifying it like this: