Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adapted lark transformer to work with v0.12 #4499

Merged
merged 4 commits into from
Nov 29, 2024
Merged

Conversation

boecklic
Copy link
Contributor

@boecklic boecklic commented Nov 28, 2024

In newer versions of lark (newer than 0.7.8 that we used previously) Token is directly subclassing str, previously it was Token(Str) (https://github.com/lark-parser/lark/blame/44a20c850ea7e0945a9db663a763abdcf1f86b88/lark/lexer.py#L113). This led to a different behavior of the index operator [].

@github-actions github-actions bot added this to the 2024-12-18 milestone Nov 28, 2024
@github-actions github-actions bot added the bug label Nov 28, 2024
@boecklic boecklic requested a review from ltclm November 28, 2024 10:34
@ltclm ltclm changed the base branch from develop-2024-12-18 to feat_PB-1241_akhet November 29, 2024 09:22
@github-actions github-actions bot removed this from the 2024-12-18 milestone Nov 29, 2024
Copy link
Contributor

@ltclm ltclm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you @boecklic
had to change the base to feat_PB-1241_akhet

@ltclm ltclm merged commit 2918d79 into feat_PB-1241_akhet Nov 29, 2024
5 checks passed
@ltclm ltclm deleted the fix_lark_parser branch November 29, 2024 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants