PB-1351 Log requests and errors to ECS #68
Merged
+449
−83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schtibe
force-pushed
the
feat-pb-1351-logging-facility
branch
from
e4f308d to
85a7e05
Compare
schtibe
force-pushed
the
feat-pb-1351-logging-facility
branch
6 times, most recently
from
5b0f45c to
708ea45
Compare
msom
reviewed
Jan 27, 2025
schtibe
force-pushed
the
feat-pb-1351-logging-facility
branch
3 times, most recently
from
4eea02c to
1e4227f
Compare
Send all API requests as well as the errors to the logging facility
It's already done in settings base
There was a distinction between 200s and 300s, but it resulted in both logging on level `info`, thus squashing these log calls
schtibe
force-pushed
the
feat-pb-1351-logging-facility
branch
from
1e4227f to
8c0d075
Compare
|
Also not sure about other Header Content, e.g. Set Cookie (https://security.stackexchange.com/questions/249442/storing-session-id-in-application-logs) |
|
Can we define which headers we want to log? It just feels unsafe to generally write all headers to the log |
schtibe
force-pushed
the
feat-pb-1351-logging-facility
branch
2 times, most recently
from
5932f25 to
cae7d76
Compare
msom
approved these changes
Jan 28, 2025
schtibe
force-pushed
the
feat-pb-1351-logging-facility
branch
3 times, most recently
from
2326698 to
85a3a25
Compare
Provide a white list that can be overwritten by the environment for which headers we allow to go to the log
schtibe
force-pushed
the
feat-pb-1351-logging-facility
branch
from
85a3a25 to
1a1d76f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Install ecs logging package and start sending log entries from the requests to our elastic stack