Merge pull request #1116 from geoadmin/pb-598-hide-zoom-buttons

PB-598: Hide zoom buttons on mobile.
geoadmin · Nov 11, 2024 · a54bbc0 · a54bbc0
2 parents f0ff0c8 + 034f4cc
commit a54bbc0
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 9 deletions.
diff --git a/src/modules/map/components/toolbox/MapToolbox.vue b/src/modules/map/components/toolbox/MapToolbox.vue
@@ -49,7 +49,7 @@ const isDrawingMode = computed(() => store.state.drawing.drawingOverlay.show)
     >
         <FullScreenButton v-if="fullScreenButton" />
         <GeolocButton v-if="geolocButton" :compass-button="compassButton" />
-        <ZoomButtons />
+        <ZoomButtons class="hide-on-mobile" />
         <Toggle3dButton v-if="toggle3dButton" />
         <slot />
     </div>
@@ -87,4 +87,10 @@ const isDrawingMode = computed(() => store.state.drawing.drawingOverlay.show)
         }
     }
 }
+
+.hide-on-mobile {
+    @include respond-below(phone) {
+        display: none;
+    }
+}
 </style>
diff --git a/tests/cypress/tests-e2e/embed.cy.js b/tests/cypress/tests-e2e/embed.cy.js
@@ -11,8 +11,6 @@ describe('Testing the embed view', () => {
         cy.get('[data-cy="mouse-position-select"]').should('not.exist')
         cy.get('[data-cy="mouse-position"]').should('not.exist')
 
-        cy.get('[data-cy="zoom-in"]').should('be.visible')
-        cy.get('[data-cy="zoom-out"]').should('be.visible')
         cy.get('[data-cy="3d-button"]').should('be.visible')
 
         cy.get('[data-cy="geolocation-button"]').should('not.exist')
@@ -104,8 +102,6 @@ describe('Testing the embed view', () => {
         cy.get('[data-cy="mouse-position-select"]').should('not.exist')
         cy.get('[data-cy="mouse-position"]').should('not.exist')
 
-        cy.get('[data-cy="zoom-in"]').should('be.visible')
-        cy.get('[data-cy="zoom-out"]').should('be.visible')
         cy.get('[data-cy="3d-button"]').should('be.visible')
 
         cy.get('[data-cy="geolocation-button"]').should('not.exist')

diff --git a/tests/cypress/tests-e2e/footer.cy.js b/tests/cypress/tests-e2e/footer.cy.js
@@ -5,6 +5,7 @@ import { WEBMERCATOR } from '@/utils/coordinates/coordinateSystems'
 
 describe('Testing the footer content / tools', () => {
     it('shows/hide the scale line depending on the map resolution, while in Mercator', () => {
+        cy.viewport(1920, 1080)
         cy.goToMapView({
             sr: WEBMERCATOR.epsgNumber,
         })

diff --git a/tests/cypress/tests-e2e/shareShortLink.cy.js b/tests/cypress/tests-e2e/shareShortLink.cy.js
@@ -38,10 +38,8 @@ describe('Testing the share menu', () => {
             cy.get('[data-cy="menu-share-section"]').click()
             // a short link should be generated as it is our first time opening this section
             cy.wait('@shortLink')
-            // We close the menu to still be able too click on the zoom button
-            cy.get('[data-cy="menu-button"]').click()
-            // zoom in the map in order to change the URL
-            cy.get('[data-cy="zoom-in"]').click()
+            // change the language in order to change the URL
+            cy.clickOnLanguage('fr')
             // checking that the shortLink value doesn't exist anymore
             cy.readStoreValue('state.share.shortLink').should('eq', null)
             // opening the general menu again