PB-66: Add new babs icons to mapviewer

[LukasJoss]

Test link

[cypress]

web-mapviewer    Run #3296

Run Properties:   Passed #3296  •  a8895f46a7: PB-66: Use class instead of id for tippy in v-for

Project	web-mapviewer
Branch Review	feat-PB-66-add-new-babs-icons-to-mapviewer
Run status	Passed #3296
Run duration	05m 03s
Commit	a8895f46a7: PB-66: Use class instead of id for tippy in v-for
Committer	Lukas Joss
View all properties for this run ↗︎

---

Test results
Failures	0
Flaky	0
Pending	21
Skipped	0
Passing	210
View all changes introduced in this branch ↗︎

[pakb]

couple questions about the whole thing :

• why have this description URL? We won't be using it, as i18n keys are then also given in the list of icons endpoint.
• I'm wondering if we should "tag" the sets with a lang ISO code value, so that we may have a lang selector alongside the choice of "Civil icons", instead of having 3 times the civil icons in the list
• When showing description on icons that aren't available in the current app lang, I would show them all (prefixed with ISO code)
• I would maybe add the description of the icon to the description of the marker, would make sense to know what kind of icon it is also outside of the drawing module

[LukasJoss]

couple questions about the whole thing :

* why have this description URL? We won't be using it, as i18n keys are then also given in the list of icons endpoint.

Should the backend for the set instead have a boolean, e.g. has_description?

* I'm wondering if we should "tag" the sets with a `lang` ISO code value, so that we may have a lang selector alongside the choice of "Civil icons", instead of having 3 times the civil icons in the list

I assume this should also be provided by the back-end?

* When showing description on icons that aren't available in the current app lang, I would show them all (prefixed with ISO code)

What do you mean with "icons that aren't available in the current app lang"? All icons should be available in all languages

* I would maybe add the description of the icon to the description of the marker, would make sense to know what kind of icon it is also outside of the drawing module

[ltkum]

Solid work. I'm not sure about the need for the translation parameter in this case (but I did not work with the icons, so maybe some descriptions will have problematic 'keys'), and I would alter the switch a bit, but I think this is otherwise good.

[ltkum]

When you give a key that doesn't exist, i18n will return the key itself and won't translate anything. Unless there is a use case I don't see, I think you don't need to add this 'translate' parameter.

[LukasJoss]

If I don't set it to false it will search through the entire dictionary for every icon which makes it laggy

[hansmannj]

Not sure if that is expected behavior: The mouseover text for single icons only appears, if the icon grid is expanded.
When only the first row is slightly visible, hovering over the icons does not fire the tooltip with the translations.

[LukasJoss]

Not sure if that is expected behavior: The mouseover text for single icons only appears, if the icon grid is expanded. When only the first row is slightly visible, hovering over the icons does not fire the tooltip with the translations.

@hansmannj this is intentional