Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PB-1192: add test move and resize legend #1149

Merged
merged 1 commit into from
Jan 22, 2025
Merged

PB-1192: add test move and resize legend #1149

merged 1 commit into from
Jan 22, 2025

Conversation

sommerfe
Copy link
Contributor

@sommerfe sommerfe commented Nov 29, 2024 •
edited by github-actions bot
Loading

@sommerfe sommerfe self-assigned this Nov 29, 2024
@sommerfe sommerfe requested review from ltshb and pakb November 29, 2024 14:27
@cypress Cypress
Copy link

cypress bot commented Nov 29, 2024 •
edited
Loading

web-mapviewer    Run #4367

Run Properties:  status check passed Passed #4367  •  git commit 19b95ea72d: Merge pull request #1149 from geoadmin/feat-pb-1192-add-test-open-move-legend-pa...
Project web-mapviewer
Branch Review develop
Run status status check passed Passed #4367
Run duration 05m 25s
Commit git commit 19b95ea72d: Merge pull request #1149 from geoadmin/feat-pb-1192-add-test-open-move-legend-pa...
Committer Felix Sommer
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 21
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 232
View all changes introduced in this branch ↗︎

@sommerfe sommerfe force-pushed the feat-pb-1192-add-test-open-move-legend-panel branch 25 times, most recently from 146b274 to 7b60134 Compare December 3, 2024 12:49
@sommerfe sommerfe force-pushed the feat-pb-1192-add-test-open-move-legend-panel branch 13 times, most recently from de66e88 to 79ed49d Compare December 4, 2024 08:43
@sommerfe sommerfe removed the request for review from ltshb December 4, 2024 08:48
@sommerfe sommerfe marked this pull request as ready for review December 4, 2024 08:48
@sommerfe sommerfe force-pushed the feat-pb-1192-add-test-open-move-legend-panel branch from 79ed49d to da2be52 Compare December 9, 2024 09:05
pakb
pakb reviewed Dec 11, 2024
View reviewed changes
Copy link
Contributor

@pakb pakb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll dig the test later, but so far a couple points that could already be fixed

src/utils/components/SimpleWindow.vue Outdated Show resolved Hide resolved
src/utils/components/SimpleWindow.vue Outdated Show resolved Hide resolved
src/utils/components/SimpleWindow.vue Outdated Show resolved Hide resolved
@sommerfe sommerfe force-pushed the feat-pb-1192-add-test-open-move-legend-panel branch 3 times, most recently from e179e8f to 4c1541c Compare December 18, 2024 14:46
@sommerfe sommerfe force-pushed the feat-pb-1192-add-test-open-move-legend-panel branch from 4c1541c to b0eaccb Compare December 19, 2024 11:32
@sommerfe sommerfe requested a review from pakb January 20, 2025 07:25
@sommerfe sommerfe force-pushed the feat-pb-1192-add-test-open-move-legend-panel branch 3 times, most recently from ce165db to 067ee64 Compare January 20, 2025 10:04
pakb
pakb approved these changes Jan 22, 2025
View reviewed changes
Copy link
Contributor

@pakb pakb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's move on, not that big of a deal if we couldn't test a drag/resize gesture. Might come later out-of-the-box in Cypress

@sommerfe sommerfe force-pushed the feat-pb-1192-add-test-open-move-legend-panel branch from 067ee64 to 924db10 Compare January 22, 2025 07:51
@sommerfe sommerfe merged commit 19b95ea into develop Jan 22, 2025
6 checks passed
@sommerfe sommerfe deleted the feat-pb-1192-add-test-open-move-legend-panel branch January 22, 2025 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pakb pakb pakb approved these changes

Assignees

@sommerfe sommerfe

Labels
feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sommerfe @pakb