-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PB-1180: Add test for changing language in mobile and desktop #1196
Open
ismailsunni
wants to merge
2
commits into
develop
Choose a base branch
from
feat-pb-1180-test-lang-selection
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+115
−1
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,108 @@ | ||
/// <reference types="cypress" /> | ||
|
||
import { isMobile } from 'tests/cypress/support/utils' | ||
|
||
function checkLanguage(lang) { | ||
// Check language in store | ||
cy.readStoreValue('state.i18n.lang').should('eq', lang) | ||
|
||
// Check UI | ||
if (isMobile()) { | ||
cy.readStoreValue('state.ui.showMenu').then((isMenuCurrentlyOpen) => { | ||
if (!isMenuCurrentlyOpen) { | ||
cy.get('[data-cy="menu-button"]').click() | ||
} | ||
}) | ||
cy.get('[data-cy="mobile-lang-selector"]').should('exist') | ||
cy.get('[data-cy="mobile-lang-selector"]') | ||
.find('option:selected') // it's a select element | ||
.invoke('text') | ||
.then((text) => { | ||
expect(text).to.be.equal(lang.toUpperCase()) | ||
}) | ||
} else { | ||
cy.get('[data-cy="menu-lang-selector"]') | ||
.find('button') | ||
.each((button) => { | ||
// Get the text of each button | ||
cy.wrap(button) | ||
.invoke('text') | ||
.then((text) => { | ||
// Check if the text is the current language | ||
if (text.trim() === lang.toUpperCase()) { | ||
// The text should be bold (primary) if it is the current language | ||
cy.wrap(button).should('have.class', 'text-primary') | ||
} else { | ||
// The text should be black if it is not the current language | ||
cy.wrap(button).should('have.class', 'text-black') | ||
} | ||
}) | ||
}) | ||
} | ||
// Check the translation of the menu button (in english: close) | ||
const closeTranslationsMobile = { | ||
de: 'Schliessen', | ||
fr: 'Fermer', | ||
it: 'Chiudere', | ||
rm: 'Serrar', | ||
en: 'Close', | ||
} | ||
const closeTranslationsDesktop = { | ||
de: 'Menü schliessen', | ||
fr: 'Fermer menu', | ||
it: 'Chiudere menu', | ||
rm: 'Serrar menu', | ||
en: 'Close menu', | ||
} | ||
if (isMobile()) { | ||
cy.get('[data-cy="menu-button"]') | ||
.invoke('text') | ||
.should('contain', closeTranslationsMobile[lang]) | ||
} else { | ||
cy.get('[data-cy="menu-button"]') | ||
.invoke('text') | ||
.should('contain', closeTranslationsDesktop[lang]) | ||
} | ||
} | ||
|
||
describe('Change language', () => { | ||
context('in mobile view', () => { | ||
it('should change the language', () => { | ||
cy.goToMapView() | ||
expect(isMobile()).to.be.true | ||
|
||
checkLanguage('en') // Initial language is 'en' | ||
|
||
// Check for all available languages | ||
const availableLanguages = ['de', 'fr', 'it', 'rm', 'en'] | ||
|
||
availableLanguages.forEach((lang) => { | ||
cy.clickOnLanguage(lang) | ||
checkLanguage(lang) | ||
}) | ||
}) | ||
}) | ||
context( | ||
'in desktop view', | ||
{ | ||
viewportWidth: 1920, | ||
viewportHeight: 1080, | ||
}, | ||
() => { | ||
it('should change the language', () => { | ||
cy.goToMapView() | ||
expect(isMobile()).to.be.false | ||
|
||
checkLanguage('en') // Initial language is 'en' | ||
|
||
// Check for all available languages | ||
const availableLanguages = ['de', 'fr', 'it', 'rm', 'en'] | ||
|
||
availableLanguages.forEach((lang) => { | ||
cy.clickOnLanguage(lang) | ||
checkLanguage(lang) | ||
}) | ||
}) | ||
} | ||
) | ||
}) |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if you swap
.then
with.should
it will add retryability to this test