Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PB-1348 : revert Cesium to 1.119.0 #1200

Merged
merged 1 commit into from
Jan 16, 2025
Merged

PB-1348 : revert Cesium to 1.119.0 #1200

merged 1 commit into from
Jan 16, 2025

Conversation

pakb
Copy link
Contributor

@pakb pakb commented Jan 16, 2025

to fix the issue with label flickering.

Also updating all other libs in the process.
I had to delete and recreate the package-lock.json for things to work properly (related to migration to Node22 maybe?)

Test link

to fix the issue with label flickering.

Also updating all other libs in the process.
I had to delete and recreate the package-lock.json for things to work properly (related to migration to Node22 maybe?)
@github-actions github-actions bot added the bug label Jan 16, 2025
Copy link

cypress bot commented Jan 16, 2025

web-mapviewer    Run #4294

Run Properties:  status check passed Passed #4294  •  git commit d4f979c9a6: Merge pull request #1200 from geoadmin/bug-PB-1348-revert-cesium
Project web-mapviewer
Branch Review develop
Run status status check passed Passed #4294
Run duration 01m 46s
Commit git commit d4f979c9a6: Merge pull request #1200 from geoadmin/bug-PB-1348-revert-cesium
Committer Pascal Barth
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 1
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 48
View all changes introduced in this branch ↗︎

Copy link
Contributor

@ltkum ltkum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Too long, didn't review :)

Do we have the information documented somewhere, that new versions of cypress cause the bug? And is the issue being worked on by the people behind cypress ? It would be a good idea to check on this from time to time to try to still update the library when possible.

@pakb pakb merged commit d4f979c into develop Jan 16, 2025
6 checks passed
@pakb pakb deleted the bug-PB-1348-revert-cesium branch January 16, 2025 09:24
@pakb
Copy link
Contributor Author

pakb commented Jan 16, 2025

Do we have the information documented somewhere, that new versions of cypress cause the bug? And is the issue being worked on by the people behind cypress ? It would be a good idea to check on this from time to time to try to still update the library when possible.

It looks like somebody has some clue on that (see Github issue in the JIRA ticket), but I don't have any idea how the Cesium community works... So wait and see

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants