PB-1299, PB-1344: Opening Drawing module with pre-loaded empty KML breaks the drawing module #1220
+104
−34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sommerfe
force-pushed
the
fix-pb-1299-drawing-mode-empty-pre-loaded-kml
branch
from
d09be62 to
b658875
Compare
web-mapviewer
|
||||||||||||||||||||||||||||
| Project |
web-mapviewer
|
| Branch Review |
develop
|
| Run status |
|
| Run duration | 01m 51s |
| Commit |
|
| Committer | Felix Sommer |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
1
|
Skipped
|
0
|
Passing
|
48
|
| View all changes introduced in this branch ↗︎ | |
sommerfe
force-pushed
the
fix-pb-1299-drawing-mode-empty-pre-loaded-kml
branch
2 times, most recently
from
ea47ec7 to
de801cc
Compare
sommerfe
changed the title
pakb
reviewed
Jan 27, 2025
| ) | ||
| cy.clickDrawingTool(EditableFeatureTypes.MARKER) | ||
| cy.get('[data-cy="ol-map"]').click(120, 240) | ||
| cy.closeDrawingMode() |
There was a problem hiding this comment.
it might maybe make sense to check that the KML created was a new one, by intercepting the request that creates it on the backend
…he drawing module
sommerfe
force-pushed
the
fix-pb-1299-drawing-mode-empty-pre-loaded-kml
branch
from
de801cc to
9337aff
Compare
pakb
approved these changes
Jan 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test link