PB-1384 : modularize proj, number and coordinate utils #1227
+19,991
−15,637
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CI said Edit: switched to the next tier of virtual hardware for our CI |
pakb
force-pushed
the
feat-PB-1384-profile-npm-modules
branch
from
3a3778d to
31c921a
Compare
in prep work to the elevation profile module, I started modularizing what will be used by both the viewer and the future elevation profile component. I used the opportunity of having a smaller scoped project to switch to Typescript entirely all the utilities. Migration to ESLint9 was also done here, meaning there are some changes because of new linter rules. Some ESLint8 plugins weren't available in ESLint9 so I had to find equivalents, but they don't have exactly the same way of linting
pakb
force-pushed
the
feat-PB-1384-profile-npm-modules
branch
from
31c921a to
9251368
Compare
now using relative path
as we are running a preview on a "from scratch" CI instance, geoadmin package has never been built (and added to the local npm registry for that matter). Building the lib with the same target in mind before running the preview script on the viewer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in prep work to the elevation profile module, I started modularizing what will be used by both the viewer and the future elevation profile component.
I used the opportunity of having a smaller scoped project to switch to Typescript entirely all the utilities. Migration to ESLint9 was also done here, meaning there are some changes because of new linter rules. Some ESLint8 plugins weren't available in ESLint9 so I had to find equivalents, but they don't have exactly the same way of linting
Test link