Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PB-432: Allow text selection in layer info popup #801

Merged
merged 1 commit into from
Apr 24, 2024
Merged

PB-432: Allow text selection in layer info popup #801

merged 1 commit into from
Apr 24, 2024

Conversation

ltshb
Copy link
Contributor

@ltshb ltshb commented Apr 23, 2024 •
edited by github-actions bot
Loading

@github-actions github-actions bot added the bug label Apr 23, 2024
@ltshb ltshb changed the base branch from bug-PB-432-layer-legend to develop April 23, 2024 08:39
@ltshb ltshb requested a review from LukasJoss April 23, 2024 08:39
@cypress Cypress
Copy link

cypress bot commented Apr 23, 2024 •
edited
Loading

Passing run #1869 ↗︎

0 158 20 0 Flakiness 0

Details:

PB-432: Allow text selection in layer info popup
Project: web-mapviewer Commit: aaca0e4d3f
Status: Passed Duration: 05:32 💡
Started: Apr 23, 2024 1:54 PM Ended: Apr 23, 2024 2:00 PM

Review all test suite changes for PR #801 ↗︎

LukasJoss
LukasJoss approved these changes Apr 23, 2024
View reviewed changes
Copy link
Contributor

@LukasJoss LukasJoss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wouldn't @extend .clear-no-ios-long-press; do the same?

@ltshb
Copy link
Contributor Author

ltshb commented Apr 23, 2024

clear-no-ios-long-press

good point I did not thought about this class I'll change it.

@ltshb ltshb force-pushed the bug-PB-432-layer-legend-2 branch from 5cbb58c to aaca0e4 Compare April 23, 2024 13:51
@ltshb ltshb merged commit 6db8ae8 into develop Apr 24, 2024
6 checks passed
@ltshb ltshb deleted the bug-PB-432-layer-legend-2 branch April 24, 2024 04:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LukasJoss LukasJoss LukasJoss approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ltshb @LukasJoss