PB-304: Treasurehunt layer not displayed #803
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Passing run #1881 ↗︎
Details:
Review all test suite changes for PR #803 ↗︎ |
|||||||||||||||
LukasJoss
force-pushed
the
fix-PB-304-treasurehunt-layer-not-displayed
branch
2 times, most recently
from
ad843c3 to
bd76269
Compare
LukasJoss
changed the title
|
Looks like this fixes the issue, nice! |
I still would like to now whats different, I did not find any difference in the initialization, and in the json file the key value is defined as empty string, somehow in the old viewer that must have been deleted to get an undefined |
pakb
approved these changes
Apr 24, 2024
There was a problem hiding this comment.
What's different I suspect is the way Javascript interprets a "falsy" value, if the key received here is null or false the previous test wouldn't trigger, but with the way you now check for "falsy-ness" (with !) now all those values (undefined, null, false, 0) will output true with a ! prefix
LukasJoss
force-pushed
the
fix-PB-304-treasurehunt-layer-not-displayed
branch
from
bd76269 to
f36c00e
Compare
LukasJoss
force-pushed
the
fix-PB-304-treasurehunt-layer-not-displayed
branch
from
f36c00e to
5a6710a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test link