Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[POC] MapLibre layer #981

Draft
wants to merge 7 commits into
base: develop
Choose a base branch
from
Draft

[POC] MapLibre layer #981

wants to merge 7 commits into from

Conversation

pakb
Copy link
Contributor

@pakb pakb commented Jul 4, 2024 •
edited
Loading

@github-actions github-actions bot changed the title [POC] MapLibre layer [POC] MapLibre layer - #minor Jul 4, 2024
@cypress Cypress
Copy link

cypress bot commented Jul 4, 2024 •
edited
Loading

web-mapviewer    Run #4352

Run Properties:  status check failed Failed #4352  •  git commit 1bb0430643: [POC] trying to improve ready event firing from OL
Project web-mapviewer
Branch Review poc-maplibre-layer
Run status status check failed Failed #4352
Run duration 34m 13s
Commit git commit 1bb0430643: [POC] trying to improve ready event firing from OL
Committer Pascal Barth
View all properties for this run ↗︎
Test results
Tests that failed  Failures 147
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 19
Tests that did not run due to a failure in a mocha hook  Skipped 37
Tests that passed  Passing 48
View all changes introduced in this branch ↗︎

Tests for review

Failed  legacyParamImport.cy.js • 18 failed tests • e2e/electron/mobile

View Output

Test Artifacts
Test on legacy param import > Coordinates import > transfers valid params to the hash part without changing them Test Replay Screenshots
Test on legacy param import > Coordinates import > loads correctly if params are already behind the hash Test Replay Screenshots
Test on legacy param import > Coordinates import > reproject LV95 coordinates param to EPSG:4326 Test Replay Screenshots
Test on legacy param import > Coordinates import > center where expected when given a X, Y coordinate in LV95 Test Replay Screenshots
Test on legacy param import > Coordinates import > center where expected when given a X, Y coordinate in LV03 Test Replay Screenshots
Test on legacy param import > Layers import > Combines all old layers_*** params into the new one Test Replay Screenshots
Test on legacy param import > Layers import > is able to import an external KML from a legacy param Test Replay Screenshots
Test on legacy param import > Layers import > is able to import an external KML from a legacy adminId query param Test Replay Screenshots
Test on legacy param import > Layers import > don't keep KML adminId in URL after import Test Replay Screenshots
Test on legacy param import > Layers import > is able to import an external KML from a legacy adminId query param with other layers Test Replay Screenshots
The first 10 failed tests are shown, see all 18 tests in Cypress Cloud.
Failed  layers.cy.js • 29 failed tests • e2e/electron/mobile

View Output

Test Artifacts
Test of layer handling > Layer in URL at app startup > starts without any visible layer added opening the app without layers URL param Test Replay Screenshots
Test of layer handling > Layer in URL at app startup > adds a layers with config to the map when opening the app layers URL param Test Replay Screenshots
Test of layer handling > Layer in URL at app startup > uses the default timestamp of a time enabled layer when not specified in the URL Test Replay Screenshots
Test of layer handling > Layer in URL at app startup > sets the timestamp of a layer when specified in the layers URL param Test Replay Screenshots
... > reads and adds an external WMS correctly Test Replay Screenshots
... > reads and adds an external WMTS correctly Test Replay Screenshots
... > handles errors correctly Test Replay Screenshots
Test of layer handling > Background layer in URL at app startup > sets the background to the topic default if none is defined in the URL Test Replay Screenshots
Test of layer handling > Background layer in URL at app startup > sets the background to the topic default if none is defined in the URL, even if a layer (out of topic scope) is defined in it Test Replay Screenshots
Test of layer handling > Background layer in URL at app startup > sets the background according to the URL param if present at startup Test Replay Screenshots
The first 10 failed tests are shown, see all 29 tests in Cypress Cloud.
Failed  drawing.cy.js • 11 failed tests • e2e/electron/mobile

View Output

Test Artifacts
Drawing module tests > Drawing mode/tools > can create marker/icons and edit them Test Replay Screenshots
Drawing module tests > KML management > deletes the drawing when confirming the delete modal Test Replay Screenshots
Drawing module tests > KML management > manages the KML layer in the layer list / URL params correctly Test Replay Screenshots
Drawing module tests > KML management > keeps the KML after a page reload, and creates a copy if it is then edited Test Replay Screenshots
Drawing module tests > KML management > manages the KML layer correctly if it comes attached with an adminId at startup Test Replay Screenshots
Drawing module tests > KML management > manages the KML layer correctly if it comes attached with an adminId at startup from a legacy URL Test Replay Screenshots
Drawing module tests > others > doesn't save an empty drawing (if not modified) Test Replay Screenshots
Drawing module tests > others > can export the drawing/profile in multiple formats Test Replay Screenshots
Drawing module tests > others > generates short links when sharing a drawing Test Replay Screenshots
Drawing module tests > others > shows a profile of a line/measure coming from service-alti data Test Replay Screenshots
The first 10 failed tests are shown, see all 11 tests in Cypress Cloud.
Failed  print.cy.js • 9 failed tests • e2e/electron/mobile

View Output

Test Artifacts
Testing print > Print UI > should populate the UI with the capabilities from mapfishprint Test Replay Screenshots
Testing print > Send print request > should send a print request to mapfishprint (basic parameters) Test Replay Screenshots
Testing print > Send print request with layers > should send a print request to mapfishprint (with layers added) Test Replay Screenshots
Testing print > Send print request with layers > should send a print request correctly to mapfishprint (with KML layer) Test Replay Screenshots
Testing print > Send print request with layers > should send a print request correctly to mapfishprint with GPX layer Test Replay Screenshots
Testing print > Send print request with layers > should send a print request correctly to mapfishprint (icon and label) Test Replay Screenshots
Testing print > Send print request with layers > should send a print request correctly to mapfishprint (KML from old geoadmin) Test Replay Screenshots
Testing print > Send print request with external layers > prints external WMS correctly Test Replay Screenshots
Testing print > Send print request with external layers > prints external WMTS correctly Test Replay Screenshots
Failed  3d/layers.cy.js • 8 failed tests • e2e/electron/mobile

View Output

Test Artifacts
Test of layer handling in 3D > add layer from search bar Test Replay Screenshots
Test of layer handling in 3D > sets the opacity to the value defined in the layers URL param or menu UI Test Replay Screenshots
Test of layer handling in 3D > sets the timestamp of a layer when specified in the layers URL param Test Replay Screenshots
Test of layer handling in 3D > reorders visible layers when corresponding buttons are pressed Test Replay Screenshots
Test of layer handling in 3D > add GeoJson layer with opacity from URL param Test Replay Screenshots
Test of layer handling in 3D > removes a layer from the visible layers when the "remove" button is pressed Test Replay Screenshots
Test of layer handling in 3D > uses the 3D configuration of a layer if one exists Test Replay Screenshots
Test of layer handling in 3D > add KML layer from drawing Test Replay Screenshots

The first 5 failed specs are shown, see all 30 specs in Cypress Cloud.

@pakb pakb force-pushed the poc-maplibre-layer branch from 9d4476d to ea1d620 Compare August 26, 2024 11:09
@pakb pakb force-pushed the poc-maplibre-layer branch 2 times, most recently from 829e4e2 to 016cc8b Compare September 20, 2024 07:45
@pakb pakb changed the base branch from master to develop September 20, 2024 07:46
@pakb pakb changed the title [POC] MapLibre layer - #minor [POC] MapLibre layer Sep 20, 2024
@pakb pakb force-pushed the poc-maplibre-layer branch 3 times, most recently from 41e4b94 to 1925e79 Compare September 20, 2024 08:15
pakb added a commit to pakb/ol-maplibre-layer that referenced this pull request Jan 8, 2025
@pakb
Add support for non Mercator projection in OL view
e3a76de 
give the opportunity to translate the zoom level before giving it to MapLibre. This makes it possible to have OL functioning with a non-Mercator projection system, and still be able to have MapLibre receiving a valid Mercator zoom level to keep the maps in sync.

You can see this code in action here : geoadmin/web-mapviewer#981
where we have our OL instance working in LV95.
@pakb pakb mentioned this pull request Jan 8, 2025
Merged
@pakb pakb force-pushed the poc-maplibre-layer branch from 1925e79 to 479db78 Compare January 8, 2025 11:15
@pakb pakb force-pushed the poc-maplibre-layer branch from 479db78 to 3e27f85 Compare January 17, 2025 09:34
pakb added 2 commits January 21, 2025 07:52
@pakb
[POC] MapLibre layer
689f1b9 
replaces all BG layers with a VectorTile equivalent
switch to mercator as default projection to make it happen (not possible yet to mix projection systems, needs some work done on the geoblocks/ol-maplibre-layer library)

fix INT staging URL : no sys service serves theses styles yet
update to MapLibre 5.0.0
@pakb
[POC] Add events when MapLibre and OL finished loading
a23579c 
so that our print vector tiles POC can hook up to them
@pakb pakb force-pushed the poc-maplibre-layer branch 2 times, most recently from 6c2d6db to 793a1e2 Compare January 21, 2025 09:23
pakb added 3 commits January 21, 2025 13:17
@pakb
[POC] Support on-the-fly LV95 reprojection
9ebe51b 
copying geoblocks/ol-maplibre-layer/ locally to be able to edit it and add the on the fly capabilities (will create a PR there when done)

Making our coordinate system calculate resolution without threshold (especially for LV95) so that it can then be used to calculate a mercator zoom level
@pakb
[POC] print vectortiles : print mode
efe4062 
adding a flag making OL requests next zoom level tiles when in between zoom levels
@pakb
[POC] print vectortiles : only one event triggered for all map renderers
1870886
@pakb pakb force-pushed the poc-maplibre-layer branch from 793a1e2 to 4c32505 Compare January 21, 2025 12:17
@pakb pakb force-pushed the poc-maplibre-layer branch from 4c32505 to d41c210 Compare January 21, 2025 12:41
@pakb
[POC] trying to improve ready event firing from OL
1bb0430 
was not waiting on some layers sometimes, might be because they were not loaded in the OL instance yet. So checking against expected visible layer count before triggering the ready action
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@pakb