Skip to content

Try running gdal in a web worker #560

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

martinRenou
Copy link
Member

@martinRenou martinRenou commented Mar 20, 2025

Description

Fixing #558

Checklist

  • PR has a descriptive title and content.
  • PR description contains references to any issues the PR resolves, e.g. Resolves #XXX.
  • PR has one of the labels: documentation, bug, enhancement, feature, maintenance
  • Checks are passing.
    Failing lint checks can be resolved with:
    • pre-commit run --all-files
    • jlpm run lint

@martinRenou martinRenou marked this pull request as draft March 20, 2025 14:29
Copy link
Contributor

Binder 👈 Launch a Binder on branch martinRenou/jupytergis/gdal_worker

Copy link
Contributor

github-actions bot commented Mar 20, 2025

Integration tests report: appsharing.space

@mfisher87 mfisher87 changed the title Try running gdal in a worker Try running gdal in a web worker Mar 20, 2025
@@ -29,7 +29,7 @@
"scripts": {
"build": "tsc -b && jlpm run cp:gdal",
"build:gallery": "python rasterlayer_gallery_generator.py",
"cp:gdal": "cp ../../node_modules/gdal3.js/dist/package/gdal3WebAssembly.data lib && cp ../../node_modules/gdal3.js/dist/package/gdal3WebAssembly.wasm lib",
"cp:gdal": "cp ../../node_modules/gdal3.js/dist/package/gdal3WebAssembly.data lib && cp ../../node_modules/gdal3.js/dist/package/gdal3WebAssembly.wasm lib && cp ../../node_modules/gdal3.js/dist/package/gdal3.js lib",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤔 Can we use brace expansion to shorten?

Suggested change
"cp:gdal": "cp ../../node_modules/gdal3.js/dist/package/gdal3WebAssembly.data lib && cp ../../node_modules/gdal3.js/dist/package/gdal3WebAssembly.wasm lib && cp ../../node_modules/gdal3.js/dist/package/gdal3.js lib",
"cp:gdal": "cp ../../node_modules/gdal3.js/dist/package/{gdal3WebAssembly.data,gdal3WebAssembly.wasm,gdal3.js} lib",

@arjxn-py arjxn-py added the enhancement New feature or request label Mar 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants