Skip to content

Restore local geotiff file support #571

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Mar 27, 2025

Conversation

arjxn-py
Copy link
Member

@arjxn-py arjxn-py commented Mar 24, 2025

Description

Local GeoTIFF support was removed in #503
#567 depends on this

Checklist

  • PR has a descriptive title and content.
  • PR description contains references to any issues the PR resolves, e.g. Resolves #XXX.
  • PR has one of the labels: documentation, bug, enhancement, feature, maintenance
  • Checks are passing.
    Failing lint checks can be resolved with:
    • pre-commit run --all-files
    • jlpm run lint

📚 Documentation preview: https://jupytergis--571.org.readthedocs.build/en/571/
💡 JupyterLite preview: https://jupytergis--571.org.readthedocs.build/en/571/lite

Copy link
Contributor

Binder 👈 Launch a Binder on branch arjxn-py/jupytergis/local-geotiff

@arjxn-py arjxn-py added the enhancement New feature or request label Mar 24, 2025
Copy link
Contributor

github-actions bot commented Mar 24, 2025

Integration tests report: appsharing.space

@arjxn-py arjxn-py requested a review from martinRenou March 24, 2025 12:28
@mfisher87 mfisher87 changed the title Get back local geotiff file support Restore local geotiff file support Mar 24, 2025
Copy link
Member

@martinRenou martinRenou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

It looks like you'll also need to change the symbology panel to handle local geotiff files there as well.

@arjxn-py arjxn-py requested a review from martinRenou March 27, 2025 12:06
@arjxn-py
Copy link
Member Author

Done, i've added handling for the local file in symbology panel too, used fromBlob from geotiffjs

Copy link
Member

@martinRenou martinRenou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@martinRenou martinRenou merged commit accdf21 into geojupyter:main Mar 27, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants