load attribute descriptions embedded ( feature catalog) #1135
Conversation
|
Affected libs:
|
|
📷 Screenshots are here! |
libs/common/domain/src/lib/repository/records-repository.interface.ts
Outdated
Show resolved
Hide resolved
libs/common/domain/src/lib/repository/records-repository.interface.ts
Outdated
Show resolved
Hide resolved
| @@ -2363,6 +2363,7 @@ describe('Gn4Converter', () => { | |||
| isPublishedToAll: true, | |||
| id: '53583', | |||
| favoriteCount: 0, | |||
| featureTypes: [], | |||
There was a problem hiding this comment.
is there a way to get a test to show that this takes in the correct value? e.g. by changing the mock values used as input?
There was a problem hiding this comment.
i don't know exactly what you mean, but there is a test which is base to test the extras.featureType describe('when extras feature catalog is defined ', () => {
and this one test can check that the extras.featureType is completed and there is object that we can show up
| ) | ||
| ) | ||
| ) | ||
| ) |
There was a problem hiding this comment.
This needs a test I'm afraid! Although it should be quite straightforward.
| ...state, | ||
| error: { otherError, notFound }, | ||
| featureCatalogLoading: false, | ||
| }) |
jahow
changed the title
|
@jahow i will report all unresolved comments on the other PR, we decided to merge both tickets in one PR to simplify and limit conflicts |
Description
This PR introduces [...]
Architectural changes
The following library now depends on [...]
Screenshots
[...]
Quality Assurance Checklist
breaking changelabelbackport <release branch>label