[Datahub] Allow disabled ogc-client cache per request #1147
Conversation
|
Affected libs: Affected apps:
|
AlitaBernachot
force-pushed
the
allow-disabling-cache-per-request
branch
from
593c2db to
3a8e928
Compare
|
📷 Screenshots are here! |
|
📷 Screenshots are here! |
|
📷 Screenshots are here! |
AlitaBernachot
force-pushed
the
allow-disabling-cache-per-request
branch
3 times, most recently
from
bde5360 to
6da7bb0
Compare
AlitaBernachot
force-pushed
the
allow-disabling-cache-per-request
branch
from
6da7bb0 to
fda5a34
Compare
| url, | ||
| options.wfsFeatureType, | ||
| cacheActive | ||
| ) | ||
| break | ||
| } | ||
| reader.load() |
There was a problem hiding this comment.
How about passing the cache param to load directly, instead of adding another Reader on top of the others (with base-cache) ? I find that the Readers are already hard to read...
I did it in my PR and it worked too : https://github.com/geonetwork/geonetwork-ui/pull/1149/files#diff-b68b461107422b0097c7a45b98e85da1f4fbbf2959a80521e3781ceeea07cb58
But that's just a suggestion, your way works fine too :)
There was a problem hiding this comment.
This was to avoid changing functions signature. Ok I will simplify and add cache param like you suggest.
There was a problem hiding this comment.
Ah I remember why I did this, it is because also i didn't want to pass the activeCache params through all the sub component, cause now i need to pass activeCache to data-view > table-view > data-table, whereas if the cacheActive option is in the Reader I would not need all this modifications. What do you think? maybe we can ask a third opinion? Which one is best:
- let all the components and sub components to decide whether to cache or not (and then, we should add
@Input activeCacheto each components/child), simpler, but need edit everywhere when a request is done - or let the reader handle this one, less modifications, but sub components won't be allowed to deactivate cache (can only be done in parent that creates the reader), or well they can, but this would need to set the activeCache of the reader before requesting data.
There was a problem hiding this comment.
Mmmh okay, explained like that your way makes actually more sense than mine! I think that no matter which component (data/table etc), the link will always have the same update frequency anyway, so it will be cached in all cases --> and that's what this ticket is all about.
AlitaBernachot
force-pushed
the
allow-disabling-cache-per-request
branch
from
03b3324 to
0513459
Compare
Description
This PR allows disabling the ogc cache per request.
How to tests
This PR is a preparation work for the next PR where components will disable/enable cache according to dataset's update frequency when fetching data (eg. table and chart). So no manual testing.
Architectural changes
A new BaseCacheReader has been introduced from which all other readers (Wfs, Csv, Gml, Geojson, Excel) inherits the
cacheActiveprivate property.Screenshots
No UI
Quality Assurance Checklist
breaking changelabelbackport <release branch>label