[Package] Changing source directory name #102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
truskovskiyk
approved these changes
Apr 2, 2024
Comment on lines
-9
to
-11
| from rich.console import Console | ||
| from rich.layout import Layout | ||
| from rich.panel import Panel |
There was a problem hiding this comment.
why do we remove this in this PR
There was a problem hiding this comment.
Unused imports. But I agree this should be separate.
| @@ -23,10 +22,10 @@ | |||
| from rich.console import Console | |||
|
|
|||
|
|
|||
| from src.pydantic_models.config_model import Config | |||
| from src.utils.save_utils import DirectoryHelper | |||
| from src.finetune.finetune import Finetune | |||
There was a problem hiding this comment.
why do we need this change?
There was a problem hiding this comment.
Unused imports. But I agree this should be separate.
Comment on lines
-7
to
-9
| from rich.console import Console | ||
| from rich.table import Table | ||
| from rich.live import Live |
There was a problem hiding this comment.
same question: I would keep renaming as one change and fixing rich as another PR
| import statistics | ||
| from src.qa.qa_tests import * | ||
| from llmtune.qa.qa_tests import * |
There was a problem hiding this comment.
please. do not do this. import only what you need
There was a problem hiding this comment.
- This has been resolved with Vivek
- We restructured the design pattern to eliminate having to import here at all
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
srcto something more descriptive #101