Disallow legacy FAST-JX unless using mercury simulation #2380
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lizzie Lundgren <[email protected]>
lizziel
added
topic: Chemical Mechanisms
|
Closing since duplicate with #2379 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Name and Institution (Required)
Name: Lizzie Lundgren
Institution: Harvard University
Describe the update
This is a companion PR to geoschem/GCClassic#62 and geoschem/GCHP#426. Those PRs update GC-Classic and GCHP CMake files to throw an error if the FASTJX compile option is selected for any mechanism except Hg. For other models that use GEOS-Chem we also need to have a run-time error if using legacy FAST-JX with any simulation other than mercury. This prevents having to update build settings for all external models that use GEOS-Chem.
Expected changes
This is a no diff update.
Reference(s)
None
Related Github Issues/PRs
geoschem/GCHP#426
geoschem/GCClassic#62