Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(flags)!: use --option=value for flags #3326

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

lbergnehr
Copy link
Contributor

This makes sure value can start with - and not mess up the parameter parsing of many programs.

  • Write the rest of the PR description and information.

What does this change

Give a summary of the change, and how it affects end-users. It's okay to copy/paste your commit messages.

For example if it introduces a new command or modifies a commands output, give an example of you running the command and showing real output here.

What issue does it fix

Closes # (issue)

If there is not an existing issue, please make sure we have context on why this change is needed. See our Contributing Guide for examples of when an existing issue isn't necessary.

Notes for the reviewer

Put any questions or notes for the reviewer here.

Checklist

  • Did you write tests?
  • Did you write documentation?
  • Did you change porter.yaml or a storage document record? Update the corresponding schema file.
  • If this is your first pull request, please add your name to the bottom of our Contributors list. Thank you for making Porter better! 🙇‍♀️

This makes sure `value` can start with `-` and not mess up the parameter
parsing of many programs.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant