feat: Initial support for cooperative-sticky rebalancing #407
+151
−40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix one bug in StreamProcessor where it assumed the passed assignments are replacing the old ones. Our consumer backends mostly work as-is, and are already passing the right values in callbacks.
lynnagara
reviewed
Dec 13, 2024
There was a problem hiding this comment.
Looks good!
Were you wanting to merge + publish as-is or do more testing against this branch?
Is it worth including a test that fails against the current cluster but works with newer versions? Attempting to commit on an existing partition during a rebalance might do it.
| # ProcessingStrategyFactory that we made in Rust: Remove | ||
| # create_with_partitions, replace with create + | ||
| # update_partitions | ||
| logger.error( |
There was a problem hiding this comment.
can we downgrade to warning if this is expected to happen on a regular basis?
| @@ -245,6 +256,10 @@ def test_consumer_polls_when_paused(self) -> None: | |||
| assert consumer.paused() == [] | |||
|
|
|||
|
|
|||
| class TestKafkaStreamsIncrementalRebalancing(TestKafkaStreams): | |||
| # Second partition assigned | ||
| offsets_p1 = {Partition(topic, 1): 0} | ||
| assignment_callback(offsets_p1) | ||
|
|
||
| create_args, _ = factory.create_with_partitions.call_args | ||
| assert factory.create_with_partitions.call_count == 2 | ||
| assert create_args[1] == offsets_p1 | ||
| assert create_args[1] == {**offsets_p1, **offsets_p0} |
There was a problem hiding this comment.
was this test change related to your other changes? since there's no cooperative rebalancing here, seems like the assertions should stay the same?
lynnagara
reviewed
Dec 13, 2024
| @@ -161,6 +161,7 @@ def __init__( | |||
| ) | |||
|
|
|||
| configuration = dict(configuration) | |||
| self.__assignment_strategy = configuration.get("partition.assignment.strategy") | |||
There was a problem hiding this comment.
sorry i said the wrong thing earlier, this should be group.protocol
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix one bug in StreamProcessor where it assumed the passed assignments
are replacing the old ones.
Our consumer backends mostly work as-is, and are already passing the
right values in callbacks.