Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref(sentry): Tweak devservices environment env variable #224

Merged

Conversation

hubertdeng123
Copy link
Member

Making this a string instead of a boolean specifically so that runners can report to Sentry under the ci environment

Copy link
Member

@IanWoodard IanWoodard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Besides our local environments, is there anywhere else we used this that we may need to update? Also, as we talked about earlier, we should set the environment to CI in CI.

@hubertdeng123
Copy link
Member Author

Actually, I think a better idea here is to check for the environment variable CI here

Copy link
Member

@IanWoodard IanWoodard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is also a reasonable approach, I did kind of like the ability to specify any environment, but this will likely be better for consistency.

@hubertdeng123 hubertdeng123 merged commit 64e5375 into main Jan 31, 2025
12 checks passed
@hubertdeng123 hubertdeng123 deleted the hubertdeng123/tweak-devservices-environment-env-variable branch January 31, 2025 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants