Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enforce size limits in feedback envelope processors #4379

Open
4 tasks
aliu39 opened this issue Dec 12, 2024 · 0 comments
Open
4 tasks

Enforce size limits in feedback envelope processors #4379

aliu39 opened this issue Dec 12, 2024 · 0 comments

Comments

@aliu39
Copy link
Member

aliu39 commented Dec 12, 2024

Copied from sentry repo, since the main work to be done is in Relay.

The long-term solution / Follow-up for:

Some context: getsentry/sentry#79326 (comment).

TLDR; right now we're truncating feedbacks in Sentry backend if they're too large. The better solution is to drop large feedbacks immediately, in Relay.


Check for message size limits on the envelope schemas, in rust. Add them if they don't exist. Make sure they're <= 4096 chars as specified in the PR above. (For envelopes we prefer to use bytes.)

  • new feedback (user_report_v2)

  • legacy feedback (user_report)

  • Rather than truncate, emit a rejected outcome for Data Category UserReportV2, and return an error for the SDK.

  • Clean up the feedback max-size option and truncate logic in the previous PR.

Follow-ups:
A separate, smaller size limit could be enforced for spam detection, to save costs. But I wouldn't about it for this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant