-
-
Notifications
You must be signed in to change notification settings - Fork 340
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Don't start the SDK inside Xcode preview #4601
Conversation
…ry-cocoa into feat/swiftui-ttid
Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
888a145 | 1235.15 ms | 1254.82 ms | 19.67 ms |
825f0cb | 1220.53 ms | 1236.18 ms | 15.65 ms |
4bca912 | 1252.42 ms | 1260.06 ms | 7.64 ms |
39b1c35 | 1209.73 ms | 1232.40 ms | 22.67 ms |
2405ba5 | 1248.37 ms | 1259.30 ms | 10.93 ms |
af1f4dd | 1238.08 ms | 1258.48 ms | 20.40 ms |
2124551 | 1265.50 ms | 1276.44 ms | 10.94 ms |
4d6f273 | 1195.63 ms | 1232.22 ms | 36.59 ms |
52e4912 | 1216.25 ms | 1226.69 ms | 10.44 ms |
3033115 | 1260.10 ms | 1263.58 ms | 3.48 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
888a145 | 21.58 KiB | 713.54 KiB | 691.95 KiB |
825f0cb | 22.31 KiB | 771.42 KiB | 749.10 KiB |
4bca912 | 22.85 KiB | 411.14 KiB | 388.29 KiB |
39b1c35 | 22.85 KiB | 408.88 KiB | 386.03 KiB |
2405ba5 | 20.76 KiB | 435.23 KiB | 414.47 KiB |
af1f4dd | 22.85 KiB | 414.71 KiB | 391.86 KiB |
2124551 | 22.85 KiB | 411.69 KiB | 388.84 KiB |
4d6f273 | 20.76 KiB | 426.93 KiB | 406.17 KiB |
52e4912 | 21.58 KiB | 418.14 KiB | 396.56 KiB |
3033115 | 22.85 KiB | 405.84 KiB | 382.99 KiB |
Previous results on branch: feat/disableSDKSwiftUIPreview
Startup times
Revision | Plain | With Sentry | Diff |
---|---|---|---|
f1ed17a | 1222.94 ms | 1241.67 ms | 18.73 ms |
b421d36 | 1234.29 ms | 1249.18 ms | 14.89 ms |
c994cb9 | 1231.63 ms | 1255.37 ms | 23.74 ms |
3578731 | 1221.36 ms | 1245.63 ms | 24.28 ms |
db8a1d5 | 1245.84 ms | 1263.08 ms | 17.24 ms |
0cb9336 | 1223.10 ms | 1244.09 ms | 20.99 ms |
3965049 | 1228.13 ms | 1242.18 ms | 14.06 ms |
9ce8938 | 1233.04 ms | 1254.67 ms | 21.63 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
f1ed17a | 22.31 KiB | 756.92 KiB | 734.61 KiB |
b421d36 | 22.30 KiB | 750.94 KiB | 728.64 KiB |
c994cb9 | 22.30 KiB | 750.89 KiB | 728.59 KiB |
3578731 | 22.30 KiB | 750.89 KiB | 728.59 KiB |
db8a1d5 | 22.30 KiB | 750.94 KiB | 728.64 KiB |
0cb9336 | 22.30 KiB | 750.89 KiB | 728.59 KiB |
3965049 | 22.30 KiB | 750.83 KiB | 728.52 KiB |
9ce8938 | 22.30 KiB | 750.82 KiB | 728.52 KiB |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You all convinced me. Thanks for the PR, @brustolin, and thanks for all the extra context, @armcknight. LGTM when adding some log messages.
@brustolin, is anything stopping us from merging this? |
I’m just waiting to finish the SwiftUI TTID PR because this code was created on top of that one, and I don’t want to add it to the other PR and have it reviewed again. |
…tsentry/sentry-cocoa into feat/disableSDKSwiftUIPreview
…tsentry/sentry-cocoa into feat/disableSDKSwiftUIPreview
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4601 +/- ##
=============================================
+ Coverage 91.198% 91.203% +0.004%
=============================================
Files 621 621
Lines 72365 72389 +24
Branches 26347 26356 +9
=============================================
+ Hits 65996 66021 +25
- Misses 6269 6270 +1
+ Partials 100 98 -2
... and 11 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
📜 Description
The SDK was running inside Xcode preview for SwiftUI and slowing things down for development.
💚 How did you test it?
Sample and Unit test
📝 Checklist
You have to check all boxes before merging:
sendDefaultPII
is enabled.🔮 Next steps