Skip to content

feat: Mark exceptions as fatal for macOS #5497

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

itaybre
Copy link
Contributor

@itaybre itaybre commented Jun 25, 2025

📜 Description

Mark exception events as crashed
Partially fixes: #5336
Still needs to mark sessions as crashed

💚 How did you test it?

📝 Checklist

You have to check all boxes before merging:

  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • I updated the wizard if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

Copy link
Contributor

Fails
🚫 Please consider adding a changelog entry for the next release.
Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Instructions and example for changelog

Please add an entry to CHANGELOG.md to the "Unreleased" section. Make sure the entry includes this PR's number.

Example:

## Unreleased

- Mark exceptions as fatal for macOS ([#5497](https://github.com/getsentry/sentry-cocoa/pull/5497))

If none of the above apply, you can opt out of this check by adding #skip-changelog to the PR description.

Generated by 🚫 dangerJS against 8c44610

Copy link

codecov bot commented Jun 25, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.016%. Comparing base (4e3915a) to head (8c44610).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##              main     #5497       +/-   ##
=============================================
- Coverage   86.228%   86.016%   -0.212%     
=============================================
  Files          401       400        -1     
  Lines        34861     34720      -141     
  Branches     15125     14797      -328     
=============================================
- Hits         30060     29865      -195     
- Misses        4759      4812       +53     
- Partials        42        43        +1     
Files with missing lines Coverage Δ
Sources/Sentry/SentryClient.m 98.474% <100.000%> (+0.008%) ⬆️
Sources/Sentry/SentrySDK.m 88.095% <ø> (ø)

... and 35 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4e3915a...8c44610. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1235.14 ms 1258.04 ms 22.90 ms
Size 23.75 KiB 858.72 KiB 834.97 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
b714cb9 1224.71 ms 1238.04 ms 13.33 ms
5cfc768 1220.74 ms 1245.06 ms 24.32 ms
e64d3d4 1241.90 ms 1260.10 ms 18.20 ms
8ea5293 1242.70 ms 1262.25 ms 19.55 ms
35c962f 1207.61 ms 1235.90 ms 28.29 ms
4e3915a 1230.02 ms 1258.90 ms 28.88 ms
d38165b 1211.41 ms 1242.49 ms 31.08 ms
d637379 1226.43 ms 1250.77 ms 24.34 ms
db9572a 1212.61 ms 1237.73 ms 25.13 ms
f97a070 1218.88 ms 1253.12 ms 34.24 ms

App size

Revision Plain With Sentry Diff
b714cb9 23.75 KiB 858.69 KiB 834.93 KiB
5cfc768 23.75 KiB 850.73 KiB 826.98 KiB
e64d3d4 23.75 KiB 855.37 KiB 831.62 KiB
8ea5293 23.75 KiB 852.24 KiB 828.49 KiB
35c962f 23.75 KiB 854.77 KiB 831.02 KiB
4e3915a 23.75 KiB 858.69 KiB 834.94 KiB
d38165b 23.75 KiB 855.37 KiB 831.62 KiB
d637379 23.75 KiB 855.38 KiB 831.63 KiB
db9572a 23.75 KiB 858.65 KiB 834.90 KiB
f97a070 23.75 KiB 858.68 KiB 834.93 KiB

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Exceptions from _crashOnException should be fatal
1 participant