Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add urlPrefix to sentry configuration #253

Merged
merged 2 commits into from
Aug 6, 2024
Merged

Add urlPrefix to sentry configuration #253

merged 2 commits into from
Aug 6, 2024

Conversation

denrase
Copy link
Collaborator

@denrase denrase commented Aug 6, 2024

📜 Description

Add urlPrefix to sentry configuration

💡 Motivation and Context

Continuation of #222

💚 How did you test it?

Unit tests

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • I updated the docs if needed
  • All tests passing
  • No breaking changes

Copy link
Contributor

github-actions bot commented Aug 6, 2024

Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against e71458e

@denrase denrase changed the title feat: Add urlPrefix to sentry configuration Add urlPrefix to sentry configuration Aug 6, 2024
@denrase
Copy link
Collaborator Author

denrase commented Aug 6, 2024

@buenaflor Building upon the work of JoydS so we can merge this.

@denrase denrase marked this pull request as ready for review August 6, 2024 12:40
@denrase denrase merged commit ff3b310 into main Aug 6, 2024
13 checks passed
@denrase denrase deleted the feat/url-prefix branch August 6, 2024 14:11
@JoydS
Copy link

JoydS commented Aug 7, 2024

Im sorry but there is a mistake in the documentation

@denrase
Copy link
Collaborator Author

denrase commented Aug 12, 2024

@JoydS Could you point me to the incorrect documentation?

@JoydS
Copy link

JoydS commented Aug 12, 2024

The example

@denrase
Copy link
Collaborator Author

denrase commented Aug 12, 2024

Sorry for not being more clear, I meant what specifically is wrong in the example?

@JoydS
Copy link

JoydS commented Aug 12, 2024

It should be "~/app/"m not "https://mysentry.invalid/"

@denrase
Copy link
Collaborator Author

denrase commented Aug 12, 2024

@JoydS Ah yes 🤦 Fixed in #254

@lukaszmielczarekdev
Copy link

Can we make a release with this feature?

@JoydS
Copy link

JoydS commented Nov 15, 2024

It supposes to be realised but it's not working, I don't know why. Everything is still minified on my side.

@lukaszmielczarekdev
Copy link

In my opinion it is not, please look at the last release date.

@buenaflor
Copy link
Contributor

hey we will make a release on Monday that will include this

@buenaflor
Copy link
Contributor

buenaflor commented Nov 18, 2024

release is out in 2.2.0, sorry for the delay

@lukaszmielczarekdev
Copy link

Thanks a lot. But it is not working for me, everything is still minified. Can anyone confirm that it works for them?

@buenaflor
Copy link
Contributor

@lukaszmielczarekdev did you follow the guide in the readme regarding also updating your beforeSend?

@lukaszmielczarekdev
Copy link

lukaszmielczarekdev commented Nov 19, 2024

The problem I have is that it doesn't send .dart files to Sentry, it only sends one package with .js files (10 pieces). There should be a second portion, much larger with .dart files. The logs say that it found 10 files first, then 0. In the previous version of the package, all files were sent, and in the latest one only one part.

config

Version 2.2.0 (prefix added)
part

Version 2.1.0
all

@buenaflor
Copy link
Contributor

buenaflor commented Nov 21, 2024

thanks for the info @lukaszmielczarekdev do you mind opening an issue here in the repo? it's easier for us this way 🙏

@lukaszmielczarekdev
Copy link

Yeah, sure. Done 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants