Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge pubspec.yaml and sentry.properties values #295

Merged
merged 8 commits into from
Jan 27, 2025

Conversation

denrase
Copy link
Collaborator

@denrase denrase commented Jan 22, 2025

📜 Description

Read both pubspec.yaml and sentry.properties, and fallback from the former to the latter if a value is missing.

💡 Motivation and Context

Closes #294

Relates to getsentry/sentry-wizard#735

💚 How did you test it?

Unit tests

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • I updated the docs if needed
  • All tests passing
  • No breaking changes

Copy link
Contributor

github-actions bot commented Jan 22, 2025

Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against e8bebcc

@denrase denrase marked this pull request as draft January 22, 2025 16:53
@denrase denrase marked this pull request as ready for review January 22, 2025 17:14
@denrase denrase enabled auto-merge (squash) January 23, 2025 09:52
@denrase denrase requested a review from buenaflor January 27, 2025 13:28
@denrase denrase merged commit 9993d26 into main Jan 27, 2025
17 of 18 checks passed
@denrase denrase deleted the feat/merge-pubspec-and-properties-config branch January 27, 2025 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot use auth token in .properties file and rest of config in pubspec.yaml
2 participants