Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: widget masks overlap when navigating between screens. #2486

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+1 −1
Open

fix: widget masks overlap when navigating between screens. #2486

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion flutter/lib/src/screenshot/widget_filter.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ class WidgetFilter {
break;
case SentryMaskingDecision.continueProcessing:
// If this element should not be obscured, visit and check its children.
element.visitChildElements(_visitList.add);
element.debugVisitOnstageChildren(_visitList.add);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This does not seem to be 100% reliable. So far in my testing, I've seen one occasion when masks were off. Never seen that before. I'll check the implementations of debugVisitOnstageChildren().

In the following screenshot (and the correct one for reference), it seems way off. Note: this has been taken while scrolling rapidly.
image
image

Copy link
Author

@thisames thisames Dec 12, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What app are you testing with? I would like to reproduce the same time, but besides that, in my tests if I scroll quickly with visitChildElements the same thing will happen (masks were off).

try comparing the test you just did using visitChildElements and debugVisitOnstageChildren.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What app are you testing with?
https://github.com/vaind/spotube/tree/sentry

in my tests if I scroll quickly with visitChildElements the same thing will happen (masks were off).
try comparing the test you just did using visitChildElements and debugVisitOnstageChildren.

Interesting, I've never noticed that before. If you have a good repro you could shere for this, I'd like to take a look.

break;
}
}
Expand Down