-
-
Notifications
You must be signed in to change notification settings - Fork 440
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add rate limit for Continuous Profiling v8 (p6) #3926
Add rate limit for Continuous Profiling v8 (p6) #3926
Conversation
continuous profiler stops when rate limited continuous profiler prevents sending chunks after being closed added profile_chunk rate limit
|
🚨 Detected changes in high risk code 🚨High-risk code has higher potential to break the SDK and may be hard to test. To prevent severe bugs, apply the rollout process for releasing such changes and be extra careful when changing and reviewing these files:
|
sentry-android-core/src/main/java/io/sentry/android/core/AndroidContinuousProfiler.java
Outdated
Show resolved
Hide resolved
sentry-android-core/src/main/java/io/sentry/android/core/AndroidContinuousProfiler.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple of comments, otherwise LGTM!
🚨 Detected changes in high risk code 🚨High-risk code has higher potential to break the SDK and may be hard to test. To prevent severe bugs, apply the rollout process for releasing such changes and be extra careful when changing and reviewing these files:
|
b0e8333
into
feat/continuous-profiling-part1
📜 Description
continuous profiler now doesn't start if offline or rate limited
continuous profiler stops when rate limited
continuous profiler prevents sending chunks after being closed
added profile_chunk rate limit
#skip-changelog
💡 Motivation and Context
Implements rate limit for Continuous Profiling
Part 6 of #3710
💚 How did you test it?
📝 Checklist
sendDefaultPII
is enabled.🔮 Next steps