Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rate limit for Continuous Profiling v8 (p6) #3926

Merged

Conversation

stefanosiano
Copy link
Member

📜 Description

continuous profiler now doesn't start if offline or rate limited
continuous profiler stops when rate limited
continuous profiler prevents sending chunks after being closed
added profile_chunk rate limit

#skip-changelog

💡 Motivation and Context

Implements rate limit for Continuous Profiling
Part 6 of #3710

💚 How did you test it?

📝 Checklist

  • I reviewed the submitted code.
  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

continuous profiler stops when rate limited
continuous profiler prevents sending chunks after being closed
added profile_chunk rate limit
@stefanosiano stefanosiano changed the base branch from main to feat/continuous-profiling-part1 November 22, 2024 15:42
Copy link
Contributor

github-actions bot commented Nov 22, 2024

Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against 14ba468

@stefanosiano stefanosiano marked this pull request as ready for review November 22, 2024 15:46
Copy link
Contributor

🚨 Detected changes in high risk code 🚨

High-risk code has higher potential to break the SDK and may be hard to test. To prevent severe bugs, apply the rollout process for releasing such changes and be extra careful when changing and reviewing these files:

  • sentry/src/main/java/io/sentry/transport/RateLimiter.java

Copy link
Member

@romtsn romtsn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of comments, otherwise LGTM!

Copy link
Contributor

github-actions bot commented Dec 6, 2024

🚨 Detected changes in high risk code 🚨

High-risk code has higher potential to break the SDK and may be hard to test. To prevent severe bugs, apply the rollout process for releasing such changes and be extra careful when changing and reviewing these files:

  • sentry/src/main/java/io/sentry/transport/RateLimiter.java

@stefanosiano stefanosiano merged commit b0e8333 into feat/continuous-profiling-part1 Dec 6, 2024
31 of 34 checks passed
@stefanosiano stefanosiano deleted the feat/continuous-profiling-part6 branch December 6, 2024 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants