Warm start detection #3937

stefanosiano · 2024-11-28T15:58:13Z

📜 Description

ActivityLifecycleIntegration:
- creates onCreate and onStart TimeSpans
- set app start type to warm in AppStartMetrics when needed
AppStartMetrics has now a method to restart appStartSpan and reset its uptime_ms
PerformanceAndroidEventProcessor now attaches activity start spans to warm starts, too
SentryPerformanceProvider doesn't create spans anymore

Confirm warm starts are registered for background starts (BroadcastReceiver)

Cold start:

Open second Activity:

Reopen first Activity without closing app:

Open first Activity after close app with Don't keep activity developer option enabled:

💡 Motivation and Context

Fixes #3896
Relates and possibly fixes #3899

💚 How did you test it?

📝 Checklist

I added tests to verify the changes.
No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
I updated the docs if needed.
I updated the wizard if needed.
Review from the native team if needed.
No breaking change or entry added to the changelog.
No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

In a followup PR:

Remove the activityCallback completely from the SentryPerformanceProvider
Create and attach spans directly in ActivityLifecycleIntegration instead of adding them to AppStartMetrics and let the PerformanceAndroidEventProcessor add them to the transaction
Avoid creating process init span using setStartUnixTimeMs as it is a testOnly method. This means care, as the method is exposed to hybrid sdks

- creates `onCreate` and `onStart` TimeSpans - set app start type to warm in AppStartMetrics when needed AppStartMetrics has now a method to restart appStartSpan and reset its uptime_ms PerformanceAndroidEventProcessor now attaches activity start spans to warm starts, too SentryPerformanceProvider doesn't create spans anymore TimeSpan.setStartUnixTimeMs now shifts other timestamps accordingly

@testonly

…t app start timestamp reverted TimeSpan.setStartUnixTimeMs to @testonly method

github-actions · 2024-11-29T11:07:01Z

Performance metrics 🚀

	Plain	With Sentry	Diff
Startup time	443.22 ms	501.19 ms	57.97 ms
Size	1.70 MiB	2.36 MiB	671.74 KiB

Previous results on branch: fix/warm-starts

Startup times

Revision	Plain	With Sentry	Diff
`c21a34f`	369.28 ms	441.12 ms	71.84 ms
`34c4186`	410.50 ms	437.28 ms	26.78 ms

App size

Revision	Plain	With Sentry	Diff
`c21a34f`	1.70 MiB	2.36 MiB	669.76 KiB
`34c4186`	1.70 MiB	2.36 MiB	669.76 KiB

…ld start was invalid (app was started in background, like via BroadcastReceiver)

… in perfv1, too updated tests

romtsn

LGTM, but I'm a bit rusty in this part of the codebase already, would love @markushi to take a look

markushi

Looking good! Nice job! Since SentryPerformanceProvider doesn't create any spans anymore it's worth mentioning that the app start spans will only be created if the SDK gets initialized before the first activity is launched. Maybe it's worth adding this to our changelog?

sentry-android-core/src/main/java/io/sentry/android/core/ActivityLifecycleIntegration.java

markushi · 2024-12-20T08:49:49Z

sentry-android-core/src/main/java/io/sentry/android/core/ActivityLifecycleIntegration.java

      final @Nullable ISpan ttidSpan = ttidSpanMap.get(activity);
      final @Nullable ISpan ttfdSpan = ttfdSpanMap.get(activity);
-      final View rootView = activity.findViewById(android.R.id.content);
-      if (rootView != null) {
+      if (activity.getWindow() != null) {


Do we still need this check? Since we have a reference to the activity, we could always call irstDrawDoneListener.registerForNextDraw

It's a safety guard: if the window is null (i'm not sure it ever happens), the FirstDrawDoneListener.registerForNextDraw returns early, and the ttid is never stopped.
In this case i just post the ttid finish on the main thread, as it should be good enough

stefanosiano · 2024-12-20T09:52:27Z

Looking good! Nice job! Since SentryPerformanceProvider doesn't create any spans anymore it's worth mentioning that the app start spans will only be created if the SDK gets initialized before the first activity is launched. Maybe it's worth adding this to our changelog?

i think this was the case before, too, as the cold start span was created by the ActivityLifecycleIntegration anyway, and the SentryPerformanceProvider spans were only added to it.
We guard the app start span creation with the firstActivityCreated flag (that we set to true on create and on pause), so there should be no app start span if the SDK is initialized after the first activity.
Or am i missing a case here?

# Conflicts: # CHANGELOG.md

stefanosiano added 2 commits November 28, 2024 16:44

ActivityLifecycleIntegration now saves SystemClock.uptimeMillis to se…

5a8a745

…t app start timestamp reverted TimeSpan.setStartUnixTimeMs to @testonly method

ActivityLifecycleIntegration now sets start type to warm even when co…

bb0b52a

…ld start was invalid (app was started in background, like via BroadcastReceiver)

stefanosiano marked this pull request as ready for review November 29, 2024 15:07

stefanosiano requested review from adinauer, romtsn and markushi as code owners November 29, 2024 15:07

stefanosiano changed the title ~~ActivityLifecycleIntegration:~~ Fix Warm start detection Dec 2, 2024

stefanosiano changed the title ~~Fix Warm start detection~~ Warm start detection Dec 2, 2024

stefanosiano and others added 5 commits December 2, 2024 16:34

ActivityLifecycleIntegration now restart app start in AppStartMetrics…

8acddb6

… in perfv1, too updated tests

updated changelog

ed06f9f

Format code

d64c243

Merge branch 'main' into fix/warm-starts

1af9a76

updated changelog

616c9f4

stefanosiano mentioned this pull request Dec 3, 2024

Warm starts cleanup #3954

Merged

7 tasks

romtsn approved these changes Dec 19, 2024

View reviewed changes

markushi approved these changes Dec 20, 2024

View reviewed changes

stefanosiano added 2 commits December 23, 2024 17:11

Merge branch 'refs/heads/main' into fix/warm-starts

ea18927

# Conflicts: # CHANGELOG.md

merged main

c0f7395

stefanosiano enabled auto-merge (squash) December 23, 2024 16:15

stefanosiano merged commit 45a4343 into main Dec 23, 2024
33 checks passed

stefanosiano deleted the fix/warm-starts branch December 23, 2024 16:19

krystofwoldrich mentioned this pull request Jan 15, 2025

Missing cold & warm app startup time data getsentry/sentry-react-native#4419

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Warm start detection #3937

Warm start detection #3937

stefanosiano commented Nov 28, 2024 •

edited

Loading

github-actions bot commented Nov 29, 2024 •

edited

Loading

Previous results on branch: fix/warm-starts

Startup times

App size

romtsn left a comment

markushi left a comment

markushi Dec 20, 2024

stefanosiano Dec 23, 2024

stefanosiano commented Dec 20, 2024 •

edited

Loading

Warm start detection #3937

Warm start detection #3937

Conversation

stefanosiano commented Nov 28, 2024 • edited Loading

📜 Description

💡 Motivation and Context

💚 How did you test it?

📝 Checklist

🔮 Next steps

github-actions bot commented Nov 29, 2024 • edited Loading

Performance metrics 🚀

Previous results on branch: fix/warm-starts

Startup times

App size

romtsn left a comment

Choose a reason for hiding this comment

markushi left a comment

Choose a reason for hiding this comment

markushi Dec 20, 2024

Choose a reason for hiding this comment

stefanosiano Dec 23, 2024

Choose a reason for hiding this comment

stefanosiano commented Dec 20, 2024 • edited Loading

stefanosiano commented Nov 28, 2024 •

edited

Loading

github-actions bot commented Nov 29, 2024 •

edited

Loading

stefanosiano commented Dec 20, 2024 •

edited

Loading