-
-
Notifications
You must be signed in to change notification settings - Fork 440
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Warm start detection #3937
Open
stefanosiano
wants to merge
8
commits into
main
Choose a base branch
from
fix/warm-starts
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Warm start detection #3937
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- creates `onCreate` and `onStart` TimeSpans - set app start type to warm in AppStartMetrics when needed AppStartMetrics has now a method to restart appStartSpan and reset its uptime_ms PerformanceAndroidEventProcessor now attaches activity start spans to warm starts, too SentryPerformanceProvider doesn't create spans anymore TimeSpan.setStartUnixTimeMs now shifts other timestamps accordingly
…t app start timestamp reverted TimeSpan.setStartUnixTimeMs to @testonly method
Performance metrics 🚀
|
…ld start was invalid (app was started in background, like via BroadcastReceiver)
stefanosiano
requested review from
adinauer,
romtsn and
markushi
as code owners
November 29, 2024 15:07
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Description
onCreate
andonStart
TimeSpansConfirm warm starts are registered for background starts (BroadcastReceiver)
Cold start:
Open second Activity:
Reopen first Activity without closing app:
Open first Activity after close app with
Don't keep activity
developer option enabled:💡 Motivation and Context
Fixes #3896
Relates and possibly fixes #3899
💚 How did you test it?
📝 Checklist
sendDefaultPII
is enabled.🔮 Next steps
In a followup PR:
SentryPerformanceProvider
ActivityLifecycleIntegration
instead of adding them toAppStartMetrics
and let thePerformanceAndroidEventProcessor
add them to the transactionsetStartUnixTimeMs
as it is a testOnly method. This means care, as the method is exposed to hybrid sdks