Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

POTEL 62 - Build PropagationContext from sampling decision #3947

Merged
merged 15 commits into from
Dec 5, 2024

Conversation

adinauer
Copy link
Member

@adinauer adinauer commented Dec 2, 2024

📜 Description

Build PropagationContext from SamplingDecision made by SentrySampler instead of parsing headers and potentially ignoring a sampling decision in case a sentry-trace header comes in with deferred sampling decision.

💡 Motivation and Context

Support deferred sampling decision

💚 How did you test it?

📝 Checklist

  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • I updated the wizard if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

Copy link
Contributor

github-actions bot commented Dec 2, 2024

Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against a70e399

Copy link
Contributor

github-actions bot commented Dec 2, 2024

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 430.21 ms 488.45 ms 58.24 ms
Size 1.65 MiB 2.31 MiB 676.08 KiB

Previous results on branch: feat/build-propagation-context-from-sampling-decision

Startup times

Revision Plain With Sentry Diff
a63c26b 320.66 ms 331.12 ms 10.46 ms
8e4417e 392.53 ms 399.55 ms 7.02 ms

App size

Revision Plain With Sentry Diff
a63c26b 1.65 MiB 2.31 MiB 676.08 KiB
8e4417e 1.65 MiB 2.31 MiB 676.07 KiB

Base automatically changed from feat/potel-61-twp-sampling-decision to 8.x.x December 2, 2024 14:24
An error occurred while trying to automatically change base from feat/potel-61-twp-sampling-decision to 8.x.x December 2, 2024 14:24
@adinauer adinauer merged commit 339b7e0 into 8.x.x Dec 5, 2024
35 checks passed
@adinauer adinauer deleted the feat/build-propagation-context-from-sampling-decision branch December 5, 2024 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants