Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not log if OtelContextScopesStorage cannot be found #4127

Merged
merged 2 commits into from
Feb 3, 2025

Conversation

adinauer
Copy link
Member

📜 Description

We're now passing a NoOpLogger to ScopesStorageFactory so it doesn't log java.lang.ClassNotFoundException: io.sentry.opentelemetry.OtelContextScopesStorage if the class isn't available.

💡 Motivation and Context

Fixes #4094

💚 How did you test it?

📝 Checklist

  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • I updated the wizard if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

Copy link
Contributor

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 350.84 ms 398.57 ms 47.73 ms
Size 1.65 MiB 2.31 MiB 678.92 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
00c8eeb 415.32 ms 428.08 ms 12.76 ms

App size

Revision Plain With Sentry Diff
00c8eeb 1.70 MiB 2.36 MiB 671.98 KiB

@adinauer adinauer merged commit 3b43bd2 into main Feb 3, 2025
38 checks passed
@adinauer adinauer deleted the fix/class-not-found-otel-scope-storage branch February 3, 2025 05:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

java.lang.ClassNotFoundException: io.sentry.opentelemetry.agent.AgentMarker
2 participants