Skip to content

Flattened PerformanceCollectionData #4505

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

stefanosiano
Copy link
Member

📜 Description

merged CpuCollectionData and MemoryCollectionData into PerformanceCollectionData
PerformanceCollectionData now contains timestamp in nanoseconds, so we don't store Date objects anymore

💡 Motivation and Context

Closes #4303
We are not storing date objects in memory anymore, and we also avoid instantiating multiple objects

💚 How did you test it?

📝 Checklist

  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • I updated the wizard if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

…lectionData

PerformanceCollectionData now contains timestamp in nanoseconds, so we don't store Date objects anymore
@stefanosiano stefanosiano marked this pull request as ready for review June 20, 2025 14:25
Copy link
Contributor

github-actions bot commented Jun 20, 2025

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 428.00 ms 446.64 ms 18.64 ms
Size 1.58 MiB 2.09 MiB 518.63 KiB

Previous results on branch: internal/flatten-performance-data

Startup times

Revision Plain With Sentry Diff
98e03f7 400.54 ms 441.78 ms 41.24 ms

App size

Revision Plain With Sentry Diff
98e03f7 1.58 MiB 2.09 MiB 518.59 KiB

removed date from frame measurements
removed ProfileMeasurementValue constructor with date
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reduce the number of object allocations
1 participant