Merge pull request #14682 from getsentry/prepare-release/8.45.0

meta(changelog): Update changelog for 8.45.0
getsentry · Dec 13, 2024 · d6aa2e7 · d6aa2e7
2 parents 81b70f3 + 734b375
commit d6aa2e7
Show file tree

Hide file tree

Showing 91 changed files with 1,612 additions and 1,044 deletions.
diff --git a/.craft.yml b/.craft.yml
@@ -142,10 +142,12 @@ targets:
     id: '@sentry-internal/eslint-config-sdk'
     includeNames: /^sentry-internal-eslint-config-sdk-\d.*\.tgz$/
 
-  # AWS Lambda Layer target
+  # TODO(v9): Remove this target
+  # NOTE: We publish the v8 layer under its own name so people on v8 can still get patches
+  # whenever we release a new v8 version—otherwise we would overwrite the current major lambda layer.
   - name: aws-lambda-layer
     includeNames: /^sentry-node-serverless-\d+.\d+.\d+(-(beta|alpha|rc)\.\d+)?\.zip$/
-    layerName: SentryNodeServerlessSDK
+    layerName: SentryNodeServerlessSDKv8
     compatibleRuntimes:
       - name: node
         versions:
@@ -157,13 +159,10 @@ targets:
           - nodejs20.x
     license: MIT
 
-  # NOTE: We publish the v8 layer under its own name so people on v8 can still get patches
-  # whenever we release a new v8 version—otherwise we would overwrite the current major lambda layer.
-
   # AWS Lambda Layer target
   - name: aws-lambda-layer
     includeNames: /^sentry-node-serverless-\d+.\d+.\d+(-(beta|alpha|rc)\.\d+)?\.zip$/
-    layerName: SentryNodeServerlessSDKv8
+    layerName: SentryNodeServerlessSDK
     compatibleRuntimes:
       - name: node
         versions:

diff --git a/.size-limit.js b/.size-limit.js
@@ -147,7 +147,7 @@ module.exports = [
     path: 'packages/svelte/build/esm/index.js',
     import: createImport('init'),
     gzip: true,
-    limit: '24 KB',
+    limit: '25 KB',
   },
   // Browser CDN bundles
   {

diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -10,6 +10,23 @@
 
 - "You miss 100 percent of the chances you don't take. — Wayne Gretzky" — Michael Scott
 
+## 8.45.0
+
+- feat(core): Add `handled` option to `captureConsoleIntegration` ([#14664](https://github.com/getsentry/sentry-javascript/pull/14664))
+- feat(browser): Attach virtual stack traces to `HttpClient` events ([#14515](https://github.com/getsentry/sentry-javascript/pull/14515))
+- feat(replay): Upgrade rrweb packages to 2.31.0 ([#14689](https://github.com/getsentry/sentry-javascript/pull/14689))
+- fix(aws-serverless): Remove v8 layer as it overwrites the current layer for docs ([#14679](https://github.com/getsentry/sentry-javascript/pull/14679))
+- fix(browser): Mark stack trace from `captureMessage` with `attachStacktrace: true` as synthetic ([#14668](https://github.com/getsentry/sentry-javascript/pull/14668))
+- fix(core): Mark stack trace from `captureMessage` with `attatchStackTrace: true` as synthetic ([#14670](https://github.com/getsentry/sentry-javascript/pull/14670))
+- fix(core): Set `level` in server runtime `captureException` ([#10587](https://github.com/getsentry/sentry-javascript/pull/10587))
+- fix(profiling-node): Guard invocation of native profiling methods ([#14676](https://github.com/getsentry/sentry-javascript/pull/14676))
+- fix(nuxt): Inline nitro-utils function ([#14680](https://github.com/getsentry/sentry-javascript/pull/14680))
+- fix(profiling-node): Ensure profileId is added to transaction event ([#14681](https://github.com/getsentry/sentry-javascript/pull/14681))
+- fix(react): Add React Router Descendant Routes support ([#14304](https://github.com/getsentry/sentry-javascript/pull/14304))
+- fix: Disable ANR and Local Variables if debugger is enabled via CLI args ([#14643](https://github.com/getsentry/sentry-javascript/pull/14643))
+
+Work in this release was contributed by @anonrig and @Zih0. Thank you for your contributions!
+
 ## 8.44.0
 
 ### Deprecations

diff --git a/biome.json b/biome.json
@@ -3,7 +3,8 @@
   "vcs": {
     "enabled": true,
     "clientKind": "git",
-    "useIgnoreFile": true
+    "useIgnoreFile": true,
+    "defaultBranch": "develop"
   },
   "organizeImports": {
     "enabled": true
@@ -17,13 +18,15 @@
         "noUnusedVariables": "error",
         "noPrecisionLoss": "error"
       },
+      "complexity": {
+        "useRegexLiterals": "error"
+      },
       "suspicious": {
         "all": false,
         "noControlCharactersInRegex": "error"
       },
       "nursery": {
-        "noUnusedImports": "error",
-        "useRegexLiterals": "error"
+        "noUnusedImports": "error"
       },
       "performance": {
         "all": true,
@@ -92,6 +95,10 @@
   "json": {
     "formatter": {
       "enabled": true
+    },
+    "parser": {
+      "allowComments": true,
+      "allowTrailingCommas": true
     }
   }
 }
diff --git a/dev-packages/browser-integration-tests/package.json b/dev-packages/browser-integration-tests/package.json
@@ -42,7 +42,7 @@
   "dependencies": {
     "@babel/preset-typescript": "^7.16.7",
     "@playwright/test": "^1.44.1",
-    "@sentry-internal/rrweb": "2.30.0",
+    "@sentry-internal/rrweb": "2.31.0",
     "@sentry/browser": "8.44.0",
     "axios": "1.7.7",
     "babel-loader": "^8.2.2",

diff --git a/dev-packages/browser-integration-tests/suites/integrations/captureConsole/test.ts b/dev-packages/browser-integration-tests/suites/integrations/captureConsole/test.ts
@@ -30,6 +30,7 @@ sentryTest('it captures console messages correctly', async ({ getLocalTestUrl, p
       extra: {
         arguments: ['console log'],
       },
+      message: 'console log',
     }),
   );
   expect(logEvent?.exception).toBeUndefined();
@@ -40,6 +41,7 @@ sentryTest('it captures console messages correctly', async ({ getLocalTestUrl, p
       extra: {
         arguments: ['console warn'],
       },
+      message: 'console warn',
     }),
   );
   expect(warnEvent?.exception).toBeUndefined();
@@ -50,6 +52,7 @@ sentryTest('it captures console messages correctly', async ({ getLocalTestUrl, p
       extra: {
         arguments: ['console info'],
       },
+      message: 'console info',
     }),
   );
   expect(infoEvent?.exception).toBeUndefined();
@@ -60,6 +63,7 @@ sentryTest('it captures console messages correctly', async ({ getLocalTestUrl, p
       extra: {
         arguments: ['console error'],
       },
+      message: 'console error',
     }),
   );
   expect(errorEvent?.exception).toBeUndefined();
@@ -70,6 +74,7 @@ sentryTest('it captures console messages correctly', async ({ getLocalTestUrl, p
       extra: {
         arguments: ['console trace'],
       },
+      message: 'console trace',
     }),
   );
   expect(traceEvent?.exception).toBeUndefined();
@@ -90,6 +95,11 @@ sentryTest('it captures console messages correctly', async ({ getLocalTestUrl, p
     }),
   );
   expect(errorWithErrorEvent?.exception?.values?.[0].value).toBe('console error with error object');
+  expect(errorWithErrorEvent?.exception?.values?.[0].mechanism).toEqual({
+    // TODO (v9): Adjust to true after changing the integration's default value
+    handled: false,
+    type: 'console',
+  });
   expect(traceWithErrorEvent).toEqual(
     expect.objectContaining({
       level: 'log',

diff --git a/dev-packages/browser-integration-tests/suites/integrations/httpclient/axios/test.ts b/dev-packages/browser-integration-tests/suites/integrations/httpclient/axios/test.ts
@@ -40,6 +40,15 @@ sentryTest(
               type: 'http.client',
               handled: false,
             },
+            stacktrace: {
+              frames: expect.arrayContaining([
+                expect.objectContaining({
+                  filename: 'http://sentry-test.io/subject.bundle.js',
+                  function: '?',
+                  in_app: true,
+                }),
+              ]),
+            },
           },
         ],
       },

diff --git a/dev-packages/browser-integration-tests/suites/integrations/httpclient/fetch/simple/test.ts b/dev-packages/browser-integration-tests/suites/integrations/httpclient/fetch/simple/test.ts
@@ -42,6 +42,15 @@ sentryTest(
               type: 'http.client',
               handled: false,
             },
+            stacktrace: {
+              frames: expect.arrayContaining([
+                expect.objectContaining({
+                  filename: 'http://sentry-test.io/subject.bundle.js',
+                  function: '?',
+                  in_app: true,
+                }),
+              ]),
+            },
           },
         ],
       },

diff --git a/...ckages/browser-integration-tests/suites/integrations/httpclient/fetch/withRequest/test.ts b/...ckages/browser-integration-tests/suites/integrations/httpclient/fetch/withRequest/test.ts
@@ -38,6 +38,15 @@ sentryTest('works with a Request passed in', async ({ getLocalTestUrl, page }) =
             type: 'http.client',
             handled: false,
           },
+          stacktrace: {
+            frames: expect.arrayContaining([
+              expect.objectContaining({
+                filename: 'http://sentry-test.io/subject.bundle.js',
+                function: '?',
+                in_app: true,
+              }),
+            ]),
+          },
         },
       ],
     },

diff --git a/...tegration-tests/suites/integrations/httpclient/fetch/withRequestAndBodyAndOptions/test.ts b/...tegration-tests/suites/integrations/httpclient/fetch/withRequestAndBodyAndOptions/test.ts
@@ -40,6 +40,15 @@ sentryTest(
               type: 'http.client',
               handled: false,
             },
+            stacktrace: {
+              frames: expect.arrayContaining([
+                expect.objectContaining({
+                  filename: 'http://sentry-test.io/subject.bundle.js',
+                  function: '?',
+                  in_app: true,
+                }),
+              ]),
+            },
           },
         ],
       },

diff --git a/...wser-integration-tests/suites/integrations/httpclient/fetch/withRequestAndOptions/test.ts b/...wser-integration-tests/suites/integrations/httpclient/fetch/withRequestAndOptions/test.ts
@@ -38,6 +38,15 @@ sentryTest('works with a Request (without body) & options passed in', async ({ g
             type: 'http.client',
             handled: false,
           },
+          stacktrace: {
+            frames: expect.arrayContaining([
+              expect.objectContaining({
+                filename: 'http://sentry-test.io/subject.bundle.js',
+                function: '?',
+                in_app: true,
+              }),
+            ]),
+          },
         },
       ],
     },

diff --git a/dev-packages/browser-integration-tests/suites/integrations/httpclient/xhr/test.ts b/dev-packages/browser-integration-tests/suites/integrations/httpclient/xhr/test.ts
@@ -40,6 +40,15 @@ sentryTest(
               type: 'http.client',
               handled: false,
             },
+            stacktrace: {
+              frames: expect.arrayContaining([
+                expect.objectContaining({
+                  filename: 'http://sentry-test.io/subject.bundle.js',
+                  function: '?',
+                  in_app: true,
+                }),
+              ]),
+            },
           },
         ],
       },

diff --git a/...ntegration-tests/suites/public-api/captureMessage/simple_message_attachStackTrace/init.js b/...ntegration-tests/suites/public-api/captureMessage/simple_message_attachStackTrace/init.js
@@ -0,0 +1,8 @@
+import * as Sentry from '@sentry/browser';
+
+window.Sentry = Sentry;
+
+Sentry.init({
+  dsn: 'https://[email protected]/1337',
+  attachStacktrace: true,
+});
diff --git a/...gration-tests/suites/public-api/captureMessage/simple_message_attachStackTrace/subject.js b/...gration-tests/suites/public-api/captureMessage/simple_message_attachStackTrace/subject.js
@@ -0,0 +1 @@
+Sentry.captureMessage('foo');
diff --git a/...ntegration-tests/suites/public-api/captureMessage/simple_message_attachStackTrace/test.ts b/...ntegration-tests/suites/public-api/captureMessage/simple_message_attachStackTrace/test.ts
@@ -0,0 +1,28 @@
+import { expect } from '@playwright/test';
+import type { Event } from '@sentry/core';
+
+import { sentryTest } from '../../../../utils/fixtures';
+import { getFirstSentryEnvelopeRequest } from '../../../../utils/helpers';
+
+sentryTest(
+  'captures a simple message string with stack trace if `attachStackTrace` is `true`',
+  async ({ getLocalTestUrl, page }) => {
+    const url = await getLocalTestUrl({ testDir: __dirname });
+
+    const eventData = await getFirstSentryEnvelopeRequest<Event>(page, url);
+
+    expect(eventData.message).toBe('foo');
+    expect(eventData.level).toBe('info');
+    expect(eventData.exception?.values?.[0]).toEqual({
+      mechanism: {
+        handled: true,
+        type: 'generic',
+        synthetic: true,
+      },
+      stacktrace: {
+        frames: expect.arrayContaining([expect.any(Object), expect.any(Object)]),
+      },
+      value: 'foo',
+    });
+  },
+);
diff --git a/dev-packages/browser-integration-tests/suites/tracing/metrics/web-vitals-inp-late/subject.js b/dev-packages/browser-integration-tests/suites/tracing/metrics/web-vitals-inp-late/subject.js
@@ -1,17 +1,19 @@
-const blockUI = (delay = 70) => e => {
-  const startTime = Date.now();
+const blockUI =
+  (delay = 70) =>
+  e => {
+    const startTime = Date.now();
 
-  function getElasped() {
-    const time = Date.now();
-    return time - startTime;
-  }
+    function getElasped() {
+      const time = Date.now();
+      return time - startTime;
+    }
 
-  while (getElasped() < delay) {
-    //
-  }
+    while (getElasped() < delay) {
+      //
+    }
 
-  e.target.classList.add('clicked');
-};
+    e.target.classList.add('clicked');
+  };
 
 document.querySelector('[data-test-id=not-so-slow-button]').addEventListener('click', blockUI(300));
 document.querySelector('[data-test-id=slow-button]').addEventListener('click', blockUI(450));

diff --git a/...wser-integration-tests/suites/tracing/metrics/web-vitals-inp-parametrized-late/subject.js b/...wser-integration-tests/suites/tracing/metrics/web-vitals-inp-parametrized-late/subject.js
@@ -1,17 +1,19 @@
-const blockUI = (delay = 70) => e => {
-  const startTime = Date.now();
+const blockUI =
+  (delay = 70) =>
+  e => {
+    const startTime = Date.now();
 
-  function getElasped() {
-    const time = Date.now();
-    return time - startTime;
-  }
+    function getElasped() {
+      const time = Date.now();
+      return time - startTime;
+    }
 
-  while (getElasped() < delay) {
-    //
-  }
+    while (getElasped() < delay) {
+      //
+    }
 
-  e.target.classList.add('clicked');
-};
+    e.target.classList.add('clicked');
+  };
 
 document.querySelector('[data-test-id=not-so-slow-button]').addEventListener('click', blockUI(300));
 document.querySelector('[data-test-id=slow-button]').addEventListener('click', blockUI(450));

diff --git a/...s/browser-integration-tests/suites/tracing/metrics/web-vitals-inp-parametrized/subject.js b/...s/browser-integration-tests/suites/tracing/metrics/web-vitals-inp-parametrized/subject.js
@@ -1,17 +1,19 @@
-const blockUI = (delay = 70) => e => {
-  const startTime = Date.now();
+const blockUI =
+  (delay = 70) =>
+  e => {
+    const startTime = Date.now();
 
-  function getElasped() {
-    const time = Date.now();
-    return time - startTime;
-  }
+    function getElasped() {
+      const time = Date.now();
+      return time - startTime;
+    }
 
-  while (getElasped() < delay) {
-    //
-  }
+    while (getElasped() < delay) {
+      //
+    }
 
-  e.target.classList.add('clicked');
-};
+    e.target.classList.add('clicked');
+  };
 
 document.querySelector('[data-test-id=not-so-slow-button]').addEventListener('click', blockUI(300));
 document.querySelector('[data-test-id=slow-button]').addEventListener('click', blockUI(450));