-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(browser): Remove browserPerformanceTimeOrigin
side-effects
#14025
base: develop
Are you sure you want to change the base?
Conversation
size-limit report 📦
|
…ry-javascript into timfish/time-side-effects
@mydea or @billyvg do you know why my changes could be causing this Replay test failure with an incorrect |
@lforst since this is now a breaking change, can I rebase this PR on top of the v9 branch? |
We already cut the |
Due to the side-effect,
browserPerformanceTimeOrigin
ends up in the non-tracing browser bundle.This change ensures that the code is only included when tracing is in use at a slight cost to the tracing bundles.