fix(browser): Remove browserPerformanceTimeOrigin side-effects
#14025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size-limit report 📦
|
…ry-javascript into timfish/time-side-effects
|
@mydea or @billyvg do you know why my changes could be causing this Replay test failure with an incorrect |
mydea
reviewed
Dec 4, 2024
|
@lforst since this is now a breaking change, can I rebase this PR on top of the v9 branch? |
We already cut the |
AbhiPrasad
approved these changes
Jan 13, 2025
| */ | ||
| export const browserPerformanceTimeOrigin = ((): number | undefined => { |
There was a problem hiding this comment.
I wonder how much of this logic we can simplify 🤔
Probably not worth the effort.
billyvg
approved these changes
Jan 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to the side-effect,
browserPerformanceTimeOriginends up in the non-tracing browser bundle.This change ensures that the code is only included when tracing is in use at a slight cost to the tracing bundles.