-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ref!: Don't polyfill optional chaining and nullish coalescing #14603
Conversation
size-limit report 📦
|
In order for us to have size-limit comparison etc, we need to ensure CI runs on v8 & v9 branches too.
0b90a9a
to
b9498ca
Compare
this still feels so scary |
Just to double check: all our versions, both browser and node, now support these two features? If so, we should also remove the eslint rule disallowing this, I guess. Actually, thinking about this, maybe before we merge this we should first adjust version support on the v9 branch? Why are Node 14 tests not failing with this 😅 |
yes
That is already part of this PR.
Node 14 supports nullish coalescing and optional chaining. |
ok, perfect, then let's |
@@ -4,6 +4,8 @@ on: | |||
branches: | |||
- develop | |||
- master | |||
- v9 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hmm why is this showing up here like this, are these changes not already on the v9 branch? is this just a GH UI problem?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah super weird, idk 🤔 the changes are definitely on v9
Resolves #8795