Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref!: Don't polyfill optional chaining and nullish coalescing #14603

Merged
merged 6 commits into from
Dec 13, 2024

Conversation

lforst
Copy link
Member

@lforst lforst commented Dec 6, 2024

Resolves #8795

Copy link
Contributor

github-actions bot commented Dec 6, 2024

size-limit report 📦

Path Size % Change Change
@sentry/browser 23.19 KB - -
@sentry/browser - with treeshaking flags 21.87 KB - -
@sentry/browser (incl. Tracing) 35.68 KB - -
@sentry/browser (incl. Tracing, Replay) 72.6 KB +0.02% +9 B 🔺
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 63.02 KB +0.01% +2 B 🔺
@sentry/browser (incl. Tracing, Replay with Canvas) 77.01 KB +0.15% +116 B 🔺
@sentry/browser (incl. Tracing, Replay, Feedback) 89.39 KB -0.01% -1 B 🔽
@sentry/browser (incl. Feedback) 39.95 KB - -
@sentry/browser (incl. sendFeedback) 27.81 KB - -
@sentry/browser (incl. FeedbackAsync) 32.6 KB - -
@sentry/react 25.87 KB - -
@sentry/react (incl. Tracing) 38.5 KB - -
@sentry/vue 27.4 KB - -
@sentry/vue (incl. Tracing) 37.52 KB - -
@sentry/svelte 23.36 KB - -
CDN Bundle 24.36 KB - -
CDN Bundle (incl. Tracing) 37.34 KB - -
CDN Bundle (incl. Tracing, Replay) 72.12 KB -0.12% -88 B 🔽
CDN Bundle (incl. Tracing, Replay, Feedback) 77.48 KB -0.1% -77 B 🔽
CDN Bundle - uncompressed 71.56 KB - -
CDN Bundle (incl. Tracing) - uncompressed 110.85 KB - -
CDN Bundle (incl. Tracing, Replay) - uncompressed 223.91 KB -0.01% -6 B 🔽
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed 237.13 KB -0.01% -6 B 🔽
@sentry/nextjs (client) 38.77 KB -0.04% -15 B 🔽
@sentry/sveltekit (client) 36.18 KB - -
@sentry/node 163.22 KB +0.18% +297 B 🔺
@sentry/node - without tracing 99.98 KB +0.17% +172 B 🔺
@sentry/aws-serverless 127.51 KB +0.17% +212 B 🔺

View base workflow run

mydea and others added 2 commits December 6, 2024 10:27
In order for us to have size-limit comparison etc, we need to ensure CI
runs on v8 & v9 branches too.
@mydea mydea force-pushed the lforst-rip-polyfills branch from 0b90a9a to b9498ca Compare December 6, 2024 10:34
@lforst
Copy link
Member Author

lforst commented Dec 11, 2024

this still feels so scary

@mydea
Copy link
Member

mydea commented Dec 12, 2024

Just to double check: all our versions, both browser and node, now support these two features? If so, we should also remove the eslint rule disallowing this, I guess.

Actually, thinking about this, maybe before we merge this we should first adjust version support on the v9 branch? Why are Node 14 tests not failing with this 😅

@lforst
Copy link
Member Author

lforst commented Dec 12, 2024

Just to double check: all our versions, both browser and node, now support these two features?

yes

If so, we should also remove the eslint rule disallowing this, I guess.

That is already part of this PR.

Actually, thinking about this, maybe before we merge this we should first adjust version support on the v9 branch? Why are Node 14 tests not failing with this 😅

Node 14 supports nullish coalescing and optional chaining.

@mydea
Copy link
Member

mydea commented Dec 12, 2024

ok, perfect, then let's :shipit:

@@ -4,6 +4,8 @@ on:
branches:
- develop
- master
- v9
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm why is this showing up here like this, are these changes not already on the v9 branch? is this just a GH UI problem?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah super weird, idk 🤔 the changes are definitely on v9

@lforst lforst requested a review from mydea December 13, 2024 08:57
@lforst lforst merged commit 1c9544b into v9 Dec 13, 2024
181 checks passed
@lforst lforst deleted the lforst-rip-polyfills branch December 13, 2024 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants